Skip to content

Rename Querystring Key for phpinfo #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2017
Merged

Rename Querystring Key for phpinfo #30

merged 2 commits into from
Jul 3, 2017

Conversation

JustinStolle
Copy link
Contributor

PHP will throw error if mod_security is on and querystring key of phpinfo is used

@JustinStolle
Rename Querystring Key for phpinfo
50994e5 
PHP will throw error if `mod_security` is on and querystring key of `phpinfo` is used
osalabs
osalabs requested changes Jul 3, 2017
View reviewed changes
Copy link
Owner

@osalabs osalabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, good point.
Could you please just make 2 changes:

  1. version is in format 1.9.YYMMDD, so it should be like 1.9.170703
  2. make query string key name as short "pi" instead of long "showphpinfo" (just trying to keep file size as small as possible :)

@JustinStolle
incorporated requested changes
0b582aa 
uses proper version number format, shortens the request key name for showing phpinfo to just `pi`
@JustinStolle
Copy link
Contributor Author

Got it, didn't recognize the version number had a format before.

@osalabs osalabs merged commit 5696626 into osalabs:master Jul 3, 2017
@JustinStolle JustinStolle deleted the patch-1 branch August 23, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osalabs osalabs osalabs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JustinStolle @osalabs