-
Notifications
You must be signed in to change notification settings - Fork 71
fix: add Python coding standards info #1686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A similar section exists here - https://github.com/oscal-compass/compliance-trestle/blob/coding-standard/CONTRIBUTING.md#code-style-and-formating. Perhpas that could be refined instead of adding a new section.
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Inspired by need to address OpenSSF requirement: To enable collaborative review, the project's source repository MUST include interim versions for review between releases; it MUST NOT include only final releases. Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add Python coding standards info Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com> * correct english Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com> * address reviewer suggestion on PEP8 link location Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com> * Trestle updating and release logistics Inspired by need to address OpenSSF requirement: To enable collaborative review, the project's source repository MUST include interim versions for review between releases; it MUST NOT include only final releases. Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com> * Fix contributing copyright. Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com> * add semantic release & tags info Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com> --------- Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
Types of changes
develop
->main
)Quality assurance (all should be covered).
Summary
Key links:
Before you merge