add support for wasm/wasip1 build without mmap support #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for writing this package. We’ve used it in production at Domainr for a long time. We’re in the midst of porting some of our infrastructure to WebAssembly + WASI, and wanted to contribute a patch.
This PR adds support for
wasm+wasip1builds in Go 1.21 via additional build tags.jsbuild tag is used for legacy (browser) WebAssembly (GOARCH=wasm GOOS=js)wasip1build tag is used for the new WASI Preview 1 in Go 1.21 (GOARCH=wasm GOOS=wasip1)I took the liberty of renaming a couple files to better map their use (App Engine being one of many targets without mmap), and updated the doc comments.