-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Landscape Keyboard #1191
Add Landscape Keyboard #1191
Conversation
LGTM |
I really appreciate your work so much, but I am worrying about the UI components which are getting more massive and unmaintainable. Refactoring the whole input view to improve the performance, etc may be the more urged things we need to do first (I am doing so). |
agree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No major issues found except #1188 which was already fixed.
I don't verify the whole function, so please do the manually test carefully
We'd better keep the commit history, except for the messy commits we can squash it. The commit message of this pull request are very clear and well organized. |
You are right. But just because rebase will break the integrity of the commits, I wanted to try the squashing. |
此项提交导致空键占位高度异常。 |
没事,能修就行。不怕出问题,就怕修不好。 |
我試了 |
Screenrecorder-2024-01-24-15-35-21-524.mp4试了一下用默认主题,一切正常,我再找找复现条件 |
你试试 {width: 100, height: 0} |
明白,打到原因了,遲點 submit PR |
Pull request
Issue tracker
Fixes will automatically close the related issues
Fixes #1038
Fixes #1111
Refs #1148
Feature
Code of conduct
Style lint
make sytle-lint
Build pass
make debug
Manually test
Code Review
Daily build
Login and download artifact at https://github.com/osfans/trime/actions
Additional Info
@cabins @isPoto If possible, please help to test and comment. Thanks.