Skip to content

fix bugs exposed by adding array test #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2020
Merged

fix bugs exposed by adding array test #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/com/github/shyiko/mysql/binlog/event/deserialization/json/JsonBinary.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,8 @@ protected void parseObject(boolean small, JsonFormatter formatter)
// checkstyle, please ignore MethodLength for the next line
protected void parseArray(boolean small, JsonFormatter formatter)
throws IOException {
int arrayOffset = this.reader.getPosition();

// Read the header ...
int numElements = readUnsignedIndex(Integer.MAX_VALUE, small, "number of elements in");
int numBytes = readUnsignedIndex(Integer.MAX_VALUE, small, "size of");
Expand Down Expand Up @@ -534,6 +536,9 @@ protected void parseArray(boolean small, JsonFormatter formatter)
}
} else {
// Parse the value ...
this.reader.reset();
this.reader.skip(arrayOffset + entry.index);

parse(entry.type, formatter);
}
}
Expand Down