kolla: use integrated pipeline configuration #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cah-link Please review. I think this should also work. This way we do not have to take care about the customised pipeline.yml file. |
osfrickler
reviewed
Apr 2, 2023
environments/kolla/configuration.yml
Outdated
| @@ -100,6 +100,10 @@ ironic_dnsmasq_dhcp_ranges: | |||
| - range: "192.168.112.50,192.168.112.60" | |||
| ironic_cleaning_network: "public" | |||
|
|
|||
| # ceilometer | |||
| enable_ceilometer_prometheus_pushgateway: "yes" | |||
| ceilometer_prometheus_pushgateway_host: "testbed-manager-0.testbed.osism.xyz" | |||
There was a problem hiding this comment.
We only have testbed-manager.testbed.osism.xyz, not sure how either this nor the overlay would have worked at all.
berendt
force-pushed
the
use-kolla-configuration
branch
2 times, most recently
from
be3315c
to
f239f85
Compare
It is better to use Kolla's built-in configuration and configure the push gateway for Prometheus through it. Revert fa57054 Signed-off-by: Christian Berendt <berendt@osism.tech>
berendt
force-pushed
the
use-kolla-configuration
branch
from
f239f85
to
cb08ad2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is better to use Kolla's built-in configuration and configure the push gateway for Prometheus through it.
Revert fa57054