Skip to content

Conversation

gansai
Copy link
Contributor

@gansai gansai commented Apr 6, 2015

After making singleton constructor of Configurator, updated Main class

After making singleton constructor of Configurator, updated Main class
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.37%) to 11.66% when pulling a54b00d on gansai:patch-2 into dfcac89 on oskopek:master.

@oskopek
Copy link
Owner

oskopek commented Apr 6, 2015

Hello @gansai! Thank you for your contribution. Next time, please submit one PR instead of two, if both commits refer to a single specific issue. You see, the automatic build on PR #14 failed to even compile, just because it references the "old" version of the Main class.

I will merge both of the PRs in one go and make a code style change on top (don't let that discourage you!). Thank you again for your contribution!

@oskopek oskopek merged commit a54b00d into oskopek:master Apr 6, 2015
@oskopek
Copy link
Owner

oskopek commented Apr 6, 2015

Also, @gansai, if you want, add yourself to AUTHORS.adoc and submit a PR!

@gansai gansai deleted the patch-2 branch April 6, 2015 16:28
@gansai
Copy link
Contributor Author

gansai commented Apr 6, 2015

Thanks @oskopek for the opportunity to contribute to Open Source.
Yes, next time, I shall submit one PR instead of multiple.

@oskopek
Copy link
Owner

oskopek commented Apr 6, 2015

Thank you for your time and effort! I merged your AUTHORS.adoc PR.

@gansai
Copy link
Contributor Author

gansai commented Apr 7, 2015

Welcome. Your work is wonderful and thanks for opportunity to contribute.

@oskopek oskopek modified the milestone: 2.0.0 Aug 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants