Skip to content

Conversation

FridaTveit
Copy link
Contributor

Added unit tests for recognized plate. Cherry-picked a comment from pull request #31 to be able to use classes which were previously nested in CharacterRecognizer (the comment pulled the nested classes out into their own files).

@coveralls
Copy link

coveralls commented Dec 20, 2016

Coverage Status

Coverage increased (+1.4%) to 13.683% when pulling 951a45a on FridaTveit:RecognizedPlateAddUnitTests into 02a9224 on oskopek:master.

@oskopek
Copy link
Owner

oskopek commented Dec 21, 2016

Hmm, seems I broke mergeability doing a rebase, due to the cherry-picked commit. Would you mind rebasing this on top of latest master? Else I can just resolve the merge conflicts myself. Othervise, looks good 👍

Copy link
Owner

@oskopek oskopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase and a merge conflict resolution.

@FridaTveit
Copy link
Contributor Author

Will do!

@FridaTveit FridaTveit force-pushed the RecognizedPlateAddUnitTests branch from 951a45a to 2d7cb45 Compare December 21, 2016 21:26
@coveralls
Copy link

coveralls commented Dec 21, 2016

Coverage Status

Coverage increased (+0.4%) to 13.892% when pulling 2d7cb45 on FridaTveit:RecognizedPlateAddUnitTests into b80b810 on oskopek:master.

@oskopek oskopek merged commit 5562e00 into oskopek:master Dec 21, 2016
@oskopek
Copy link
Owner

oskopek commented Dec 21, 2016

Thanks! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants