Fixed TODO in FrameMain. #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FridaTveit
force-pushed
the
FixTodoExceptionInFrameMain
branch
from
b00624f to
b3dd3fa
Compare
oskopek
requested changes
Dec 22, 2016
| this.parentFrame.recognitionLabel.setText("failed"); | ||
| ex.printStackTrace(); | ||
| return; | ||
| this.parentFrame.recognitionLabel.setText(recognizedText); |
There was a problem hiding this comment.
Is there any reason why you moved these two UI calls into the try block? Other than the fact that you can then omit two return statements in the catch blocks. If not, I'd be more comfortable adding the two returns and moving this back out of the try block. It shouldn't really matter execution-wise, but it's cleaner to have as short try blocks as possible.
There was a problem hiding this comment.
No, it was just to omit the two return statements. Okay, will move them back :)
| } | ||
|
|
||
| private void setFailedAndPrintStackTrace(Exception exception) { | ||
| this.parentFrame.recognitionLabel.setText("failed"); |
There was a problem hiding this comment.
Optional: Remove all the this calls, if you feel like it :) In the spirit of #41
…ssary this. statements.
FridaTveit
force-pushed
the
FixTodoExceptionInFrameMain
branch
from
b3dd3fa to
0d1e46e
Compare
oskopek
approved these changes
Dec 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed catch exception to catch specific exceptions.