Issue #41: Removed unneeded uses of 'this' in HoughTransformation #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Frida, unfortunately I will not be able to review these PRs this week. I
will probably get to it this weekend.
…On Mon, Jan 9, 2017, 12:59 FridaTveit ***@***.***> wrote:
Issue #41 <#41>.
------------------------------
You can view, comment on, or merge this pull request online at:
#63
Commit Summary
- Issue #41: Removed unneeded uses of 'this' in HoughTransformation
File Changes
- *M*
src/main/java/net/sf/javaanpr/imageanalysis/HoughTransformation.java
<https://github.com/oskopek/javaanpr/pull/63/files#diff-0> (76)
Patch Links:
- https://github.com/oskopek/javaanpr/pull/63.patch
- https://github.com/oskopek/javaanpr/pull/63.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#63>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABulBEWeNi7J74KrEjK0B2rl4trPFgKiks5rQiEygaJpZM4LeL8K>
.
|
|
No problem :) |
oskopek
requested changes
Jan 13, 2017
| this.bitmap = new float[width][height]; | ||
| maxPoint = null; | ||
| bitmap = new float[width][height]; | ||
| this.width = width; |
There was a problem hiding this comment.
Lets make width and height final. I know this wasn't the aim of your PR, but it will be way easier to reason about all future changes this way.
oskopek
approved these changes
Jan 13, 2017
|
Merging now, I'll apply the changes myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #41.