Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OsmAnd Cloud First start issues - Not possible to apply / Conflicts #17883

Closed
pordini opened this issue Aug 10, 2023 · 9 comments · Fixed by #19274, #19276, #19318, #19358 or #19368
Closed

OsmAnd Cloud First start issues - Not possible to apply / Conflicts #17883

pordini opened this issue Aug 10, 2023 · 9 comments · Fixed by #19274, #19276, #19318, #19358 or #19368
Assignees
Labels
Milestone

Comments

@pordini
Copy link

pordini commented Aug 10, 2023

🚀 feature request

Description

The wizard on first start to restore from Osmand Cloud seems incomplete when you choose "what to sync". If you use this option you get the screen with three toggles to choose what to sync. However, you cannot "apply" or "save" this selection, there is no other button. If you then go back, you're just dropped into the standard sync screen.

Additionally, I had 17 sync conflicts on a new install, having to indicate that I want to use the cloud version on every one of them.

Describe the solution you'd like

Just a more complete out of box experience.
Also it might be good to have the cloud restore feature be a bit more prominent in the first screen, it's now hidden in the menu.
Additionally, I think there should be no conflicts with a completely new install, cloud should be primary and override any defaults that came with the install (but I might obviously be wrong on that).

Describe alternatives you've considered

I've considered not changing anything and keeping it the way it is.

@vshcherb
Copy link
Member

Conflicts on new install are normal cause you have already settings / profiles on a new device, so we don't how to distinguish yet if something was changed in settings or settings were changed because of a new version. In that case you should be able to restore and overwrite.

@vshcherb
Copy link
Member

I think we should treat situation as special that no backup was done before and suggest to restore All from backup (regardless conflicts) or suggest to go to standard menu with conflicts / overwrites tetc.

@DmitryAlexei
Copy link
Contributor

DmitryAlexei commented Aug 21, 2023

OsmAnd~ 4.6.0#648m, released: 2023-08-19

Steps to reproduce:

  • Install OsmAnd from Google play
  • tap tree dots in the top right corner on the Welcome screen
  • chose Restore from OsmAnd Cloud
  • enter email used for Cloud account and confirm email
  • tap Choose what to sync

Actual result:

  • see video
  • after tapping on Choose what to sync you are redirected to Back up screen. On that screen, you cannot choose items for synchronization, that should be available with PRO subscription. The switches are set as if you had an Osmand Cloud Basic. You cannot confirm your choice, only Back arrow is available.
  • when you tap Back arrow, you are redirected to OsmAnd cloud last sync screen. There are 17 sync conflicts on a fresh install.
video choose what to sync screen bug
Screen_Recording_20230821_152631_OsmAnd_1.mp4

@vshcherb vshcherb changed the title OOBE cloud restore wizard just ends OsmAnd Cloud First start issues - Not possible to apply / Conflicts Sep 4, 2023
@vshcherb vshcherb added this to the 4.7-android milestone Sep 4, 2023
@vshcherb
Copy link
Member

vshcherb commented Feb 1, 2024

Conflict types happen on first type installation:

  1. Maps (first downloaded maps)
  2. General settings
  3. All Profiles settings (!)
  4. Map sources (?)
  5. Itinerary (?)
  6. English TTS (?)

@vshcherb
Copy link
Member

vshcherb commented Feb 2, 2024

To do
There should be no conflicts in simple case scenario:

Ideas to implement:

  • Treat empty files as non existing (it means ok to synchronize) - should solve Map sources, Itinerary and many many issues!
  • Do not backup standard files which are always packaged in the app - English TTS
  • Do not save default values in files, so if we say Map zoom 15 by default it should not be saved into files
  • Split General settings (same for all Profiles) into 2 files. So everything that's not changed by user won't be synchornized. For example setting of last viewed location, last open tab and other (non-directly controllable by user) will be saved in file that's not backed up in OsmAnd Cloud.

@Chumva Chumva linked a pull request Mar 8, 2024 that will close this issue
@Chumva Chumva closed this as completed Mar 8, 2024
@Chumva Chumva linked a pull request Mar 8, 2024 that will close this issue
@vshcherb vshcherb reopened this Mar 12, 2024
@vshcherb
Copy link
Member

vshcherb commented Mar 12, 2024

  • Audio files couldn't download..
  • Still lots of track conflicts (don't know how to fix) - 300 local upload (after fresh installation)
  • Global and General settigns should be consided as non conflicts if it's first sync (downloaded from cloud)
  • Sort Local/Cloud by modified timestampl

This was linked to pull requests Mar 15, 2024
@Chumva Chumva reopened this Mar 21, 2024
@Chumva Chumva linked a pull request Mar 21, 2024 that will close this issue
@dmpr0 dmpr0 reopened this Mar 27, 2024
@dmpr0
Copy link
Contributor

dmpr0 commented Mar 27, 2024

Review

Screenshot
  • Browse map profile conflict after login.
How test was performed
  • Delete all data for Cloud account
  • Clear storage for OsmAnd
  • Login into cloud account, upload local changes (profiles and settings)
  • Clear storage for OsmAnd
  • Login into Cloud account
  • Conflict
Device & App info
Device : bluejay
Brand : google
Manufacturer : Google
Model : Pixel 6a
Product : bluejay_beta
Build : AP21.240216.010
Version : 14
App Version : OsmAnd~
Apk Version : 4.7.0#1930m 4700

Screenshot
  • All profile shows up as Cloud change

@vshcherb vshcherb closed this as completed Apr 1, 2024
@vshcherb vshcherb reopened this Apr 1, 2024
@vshcherb
Copy link
Member

vshcherb commented Apr 1, 2024

To do
Properly test on fresh version.

First appeared conflict on "Browse map", once it was downloaded as cloud version conflict appeared on "Global Settings", later conflict on "Quick actions", later on "Moped..." something weird...

Test scenario
Install fresh version, login to cloud, select things to backup. "Download ALL" Cloud version.
Should be no conflicts and no things to be uploaded after.

@alex-osm
Copy link
Contributor

9e778d5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment