This repository was archived by the owner on Jun 10, 2024. It is now read-only.
Add GeoJSON serialization to Area object #59
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the
Area
object haswkb
andwkt
methods, but lacks thegeojson
method.I guess this is because the
geojson
methods inNode
andWay
are implemented on the node-osmium side rather than relying on libosmium's GeoJSON serialization; with the current API, the same thing is not possible to do for areas.I've hacked up a fix that uses libosmium's
GeoJSONFactory
to serialize anArea
, and then parses the resulting string usingJSON.parse
. It feels a bit iffy, but seems to do the job.Since this is my first dive into node-osmium/libosmium, I totally expect there to be better ways to do this. Any pointers on alternatives or improvements would be great!