Fixing code smells #181
Merged
Fixing code smells #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For listing the smells fixed, did you click on the permanent link thing? |
|
Looks like I didn't. Let me fix that! I will add it per class, instead of per issue. |
matthieun
approved these changes
Jul 26, 2018
matthieun
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following were fixed:
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&issues=AWSBg5LAl6vpliCeK68L&open=AWSBg5LAl6vpliCeK68L
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&issues=AWSBg5Mgl6vpliCeK69N&open=AWSBg5Mgl6vpliCeK69N
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&issues=AWSBg5H2l6vpliCeK62s&open=AWSBg5H2l6vpliCeK62s
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&issues=AWSBg5QPl6vpliCeK6_R&open=AWSBg5QPl6vpliCeK6_R
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&issues=AWSBg5O8l6vpliCeK6-W&open=AWSBg5O8l6vpliCeK6-W
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&issues=AWSBg5N3l6vpliCeK6-H&open=AWSBg5N3l6vpliCeK6-H
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&issues=AWSBg5PIl6vpliCeK6-f&open=AWSBg5PIl6vpliCeK6-f
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&issues=AWSBg5DRl6vpliCeK6y-&open=AWSBg5DRl6vpliCeK6y-
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&issues=AWSBg5DKl6vpliCeK6yw&open=AWSBg5DKl6vpliCeK6yw
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&issues=AWSBg5Dil6vpliCeK6zX&open=AWSBg5Dil6vpliCeK6zX
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&issues=AWSBg5Dgl6vpliCeK6zV&open=AWSBg5Dgl6vpliCeK6zV
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&issues=AWSBg5GZl6vpliCeK61E&open=AWSBg5GZl6vpliCeK61E
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&issues=AWSBg4y3l6vpliCeK6p9&open=AWSBg4y3l6vpliCeK6p9
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&issues=AWSBg4y7l6vpliCeK6p-&open=AWSBg4y7l6vpliCeK6p-
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&open=AWSBg5Byl6vpliCeK6xZ&resolved=false&severities=MAJOR(fixed by Lucas in Fixed some code smells. #180)