Apply a set of changes to an Atlas as a view #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test change ideas * more * better comments * test skeleton * test and more details * more testing and validation * refactoring * validation public * move around and fix test * touchup * code review comments and shallow bloated features and more testing * added bloated relation * added test * added relation testing to edge and node * fix compilation errors * finished bloated features and related tests * added missing change items
* few changes and some tests * more tests * add synchronized * code review comments
* Fixed entitiesFor if an entity was missing * Checkstyle and comment change * ChangeNodes now filter out edges which are connected but do not exist * ChangeNodes now filter out parent relations which do not exist. * Checkstyle correction in BloatedAtlas interface BloatedEntity, and FeatureChange comment update. * Added a ChangeAtlasTest and ChangeAtlasTestRule. Remove these before PR * Implemented proper bounding for all the bloated entities * Removed local ChangeAtlasTest * Fixed spotless errors. but now unit tests are failing * Fixed a bunch of issues with bounds calculation * Spotless
* Fixed failing unit tests * Fixed a typo
…ge (#286) * with failing tests * Validation * synchronize add and get
* Edges now filter themselves out if one of their connected nodes is missing * Relations now filter out members which do not exist. ChangeAtlas filters empty/shallow relations * Added a test to demonstrate that shallow relation removal is robust * Spotless apply * Added some additional relation tests * Updated a comment
* tests shuffle * All tests * spotless * logger not used
* compilation and sonar * forgotten some methods * package simplification and Javadoc * forgot tests
* add more complex unit tests * AtlasChangeGenerator * Added shortcuts for tags
* Added feature change mergeability * Attempt merge in change * more tests * even more tests * last one?
* relation member feature merging broken * Merge relations in many more places * Fix tests and change osmIdentifier API in relation * Added equality tests * Some cleanup from testing * Fixed tests and added new relation based generator
* Keep track of explicitly removed relation members * use method overloading
…d after Atlas (#293) * Started working on a diff generator * Working on basic AtlasDiff * Still trying to make valid test case * Removed relations from test atlas * Removed node from before atlas * Still working on diff * Continuing draft of the AtlasDiff * Saving temporary working changes * Lots more doc comments * Added more comments * Fixed compilation errors after rebase * Working on modified entities, more comments * Working on modify case. * Lots of new stuff. Doesnt compile lol * Trying node diffs * Trying to get parent relations test to work * Refactor name * Working on relation support. THings may need to change * More progress * getTagChangeIfNecessary now respects useBloated and saveGeo flags. Also fixed a bug in parentRelationIfNec * Finished member in relation diffing * Added edge diff * Added the rest of the changeIfNecessary method * Relation diffs and more testing * Finished implementing tests * Checkstyle and spotless * Added PackedAtlasCloning equality to tests * Updated a test * Tests still failing even after rebase :( * Isolating bug using testatlas * Trying to fix bug... * Further bugfix. Using non-bloated entities still does not work * Expose bug when using non-bloated entities * Bug fix in place. Disallowing non-Bloated entities for FeatureChanges. Need to refactor stuff. * Removed all geometry matching related code. This feature is not necessary due to improved WaySectionProcessor. * Removed TODOs in AtlasDiff * Removed useBloatedEntities option * AtlasDiff now returns an Optional<Change>, and empty Changes are disallowed by the validator * Fixed Sonar issues in AtlasDiff and AtlasDiffHelper * Refactored interface for BloatedRelation::withMembers * Rename variables for clarity * Fixed awkward copy-pasted typo * Minor method name refactor * Fixed a unit test that used a non-Bloated type to create a feature change * Refactored withMembers to be more null-safe * Added javadoc * Removed old method
matthieun
changed the title
![sonarcloud[bot]](https://avatars.githubusercontent.com/in/12526?s=60&v=4){kind=small}
There was a problem hiding this comment.
SonarQube analysis found issues:
Including the following issue(s) which could not be reported in line:
Code Smell: 1 duplicated blocks of code must be removed. (more)
|
Closing until sonar issues are resolved. |
There was a problem hiding this comment.
SonarQube analysis found issues:
Including the following issue(s) which could not be reported in line:
There was a problem hiding this comment.
SonarQube analysis found issues:
Including the following issue(s) which could not be reported in line:
matthieun
changed the title
There was a problem hiding this comment.
SonarQube analysis found issues:
Including the following issue(s) which could not be reported in line:
| */ | ||
| @Deprecated | ||
| @Override | ||
| public Optional<Atlas> subAtlas(final Predicate<AtlasEntity> matcher) |
There was a problem hiding this comment.
| */ | ||
| @Deprecated | ||
| @Override | ||
| public Optional<Atlas> subAtlas(final Polygon boundary) |
There was a problem hiding this comment.
lucaspcram
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Apply a set of changes to an Atlas as a view. Related PRs to this branch are listed here:
#281
Potential Impact:
New Feature
Unit Test Approach:
Added a lot of unit tests for all the related use cases.
Test Results:
Tests pass.
In doubt: Contributing Guidelines