Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing countries in JOSM list #23

Closed
pnorman opened this issue Oct 21, 2013 · 2 comments · Fixed by #50
Closed

Missing countries in JOSM list #23

pnorman opened this issue Oct 21, 2013 · 2 comments · Fixed by #50
Labels

Comments

@pnorman
Copy link
Contributor

pnorman commented Oct 21, 2013

When using imagery.xml in JOSM country codes are not listed in the available entries list.

@pnorman
Copy link
Contributor Author

pnorman commented Nov 2, 2013

Currently this information isn't recorded. The two obvious ways are to change the schema to add a country or to change the directory structure to add per-country directories to be able to infer a country.

Pros of changing the schema

  • Keeps each JSON self-contained
  • Doesn't require re-arranging
  • Duplicates to some extent the information in the directory layout

Pros of changing the directory structure

  • Doesn't require schema changes
  • Avoids duplication
  • Means JSON files are no longer self-contained

I'm thinking of preparing a pull request to add it as part of the schema, but thoughts welcome

@jfirebaugh
Copy link
Contributor

I would prefer changing the schema. Imagery can cover multiple countries, so using the directory structure seems awkward.

@pnorman pnorman mentioned this issue Dec 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants