Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arenda,PH] Update TMS and extent based on newly processed imagery #724

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

maning
Copy link
Contributor

@maning maning commented Oct 21, 2019

We processed another batsh of drone images. This covers the whole AOI with updated OAM TMS.

@grischard
Copy link
Collaborator

Can you please make sure your source json files are formatted in a human-readable way?

@grischard
Copy link
Collaborator

Sorry @maning, I've reverted this:

  • There's no license linked
  • There's no privacy policy
  • The json files aren't formatted properly

I understand and appreciate your eagerness to improve the index, but please let the maintainers review and help first :)

@maning
Copy link
Contributor Author

maning commented Oct 21, 2019

@grischard Thanks for reviewing, but this was just an update of a previous data which passed all automated checks.

I agree that I should have reformatted it in human-readable form but all other data remain the same as before except for polygon and new URL. If this PR does not comply with the agreed standards it should have at least failed the automated tests.

@grischard
Copy link
Collaborator

That's why we have maintainers :). I see that you also merged your previous PR yourself.

We'd love improvements to our automated checks. Some legacy sources don't have licenses or privacy policies either, so good tests would require a bit of travis-fu to only test new files.

@maning
Copy link
Contributor Author

maning commented Oct 21, 2019

Understood, looking forward to the updated guides before I do another PR.

@cicku cicku deleted the arenda-ph-update branch January 10, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants