feat(osmoutils): coin math helpers #6427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Notice This PR modifies an in-repo Go module. It is one of:
The dependent Go modules, especially the root one, will have to be Please follow the instructions below:
Please let us know if you need any help. |
p0mvn
added
V:state/compatible/backport
czarcas7ic
approved these changes
Sep 18, 2023
|
Merging with one ACK since helpers are simple and the majority of the diff is stemming from code duplication of similar helpers |
mergify bot
pushed a commit
that referenced
this pull request
Sep 18, 2023
* feat(osmoutils): coin math helpers * updates * go mod (cherry picked from commit d00cb3e) # Conflicts: # CHANGELOG.md # go.mod # go.sum
6 tasks
p0mvn
added a commit
that referenced
this pull request
Sep 19, 2023
p0mvn
added a commit
that referenced
this pull request
Sep 20, 2023
p0mvn
added a commit
that referenced
this pull request
Sep 20, 2023
p0mvn
added a commit
that referenced
this pull request
Sep 20, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Reimplemented the same functionality 3 times while working on volume splitting.
Realized that upstream SDK supports a subset of these but not all.
I think it still makes sense to have them in our osmoutils for the speed of iteration and exhaustive support
Testing and Verifying
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)