Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor protorev allocation speedup #7498

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

ValarDragon
Copy link
Member

Really minor (only because protorev is dominated by wasted CL iterators) speedup to protorev's binary search, by removing two extra heap allocs per hot loop.

@ValarDragon ValarDragon added V:state/compatible/backport State machine compatible PR, should be backported A:no-changelog A:backport/v23.x backport patches to v23.x branch labels Feb 16, 2024
@ValarDragon ValarDragon merged commit ec6bd51 into main Feb 16, 2024
1 check passed
@ValarDragon ValarDragon deleted the dev/minor_protorev_mut_speedup branch February 16, 2024 15:29
@ValarDragon ValarDragon added the A:backport/v22.x backport patches to v22.x branch label Feb 16, 2024
mergify bot pushed a commit that referenced this pull request Feb 16, 2024
mergify bot pushed a commit that referenced this pull request Feb 16, 2024
ValarDragon added a commit that referenced this pull request Feb 16, 2024
(cherry picked from commit ec6bd51)

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
ValarDragon added a commit that referenced this pull request Feb 16, 2024
(cherry picked from commit ec6bd51)

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v22.x backport patches to v22.x branch A:backport/v23.x backport patches to v23.x branch A:no-changelog V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants