Minor state compatible speedups to txfees #7535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
requested review from
nicolaslara,
p0mvn and
AlpinYukseloglu
as code owners
ValarDragon
added
V:state/compatible/backport
mattverse
approved these changes
Feb 19, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
(cherry picked from commit d563553)
ValarDragon
added a commit
that referenced
this pull request
Feb 19, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty minor speedups to txfees. This is taking a pretty small amount of time in profiles, but driveby noticed it, hence PR'ing slight improvements. THere are better improvements via reducing the number of math ops in a state breaking change, which we should eventually do.
Also made some slight speedups to relevant ops in upstream SDK, which we should get on next math version bump. (cosmos/cosmos-sdk#19467, cosmos/cosmos-sdk#19466)