-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use .from() instead of deprecated from() from igraph #22
Conversation
also tagging @fkgruber 😸 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to export .from
so that the eval(parse(text = ))
trick should become unnecessary: igraph/rigraph#1435. For now, this looks good, thanks!
@osofr we're currently working on releasing the new igraph version on CRAN. Could you please update your package on CRAN to avoid its being broken by igraph? Thank you. 🙏 |
Hi Maelle, thanks |
@fkgruber yes, submitting this version to CRAN so that when igraph hits CRAN, your package isn't broken. Thanks a lot for your help. |
@osofr I will submit the current master version to CRAN |
When are you plannig to submit to CRAN? |
we're working on it this week cc @krlmlr |
so, the sooner you submit yours the better. I'm sorry I wasn't more explicit when I made this PR this summer! |
A new version of simcausal has been published: |
👋 @osofr! I'm opening this PR on behalf of the igraph R package team as we prepare the next release of igraph. The
from()
function is being hard-deprecated.