Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use .from() instead of deprecated from() from igraph #22

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Jul 17, 2024

👋 @osofr! I'm opening this PR on behalf of the igraph R package team as we prepare the next release of igraph. The from() function is being hard-deprecated.

@maelle maelle mentioned this pull request Jul 17, 2024
@maelle
Copy link
Contributor Author

maelle commented Jul 17, 2024

also tagging @fkgruber 😸

Copy link

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to export .from so that the eval(parse(text = )) trick should become unnecessary: igraph/rigraph#1435. For now, this looks good, thanks!

@osofr osofr merged commit bce5ad7 into osofr:master Jul 18, 2024
@maelle
Copy link
Contributor Author

maelle commented Oct 7, 2024

@osofr we're currently working on releasing the new igraph version on CRAN. Could you please update your package on CRAN to avoid its being broken by igraph? Thank you. 🙏

@maelle maelle mentioned this pull request Oct 7, 2024
@fkgruber
Copy link

fkgruber commented Oct 7, 2024

Hi Maelle,
I will take a look at this changes

thanks
Fred

@fkgruber
Copy link

fkgruber commented Oct 7, 2024

Hi @maelle,
I see that @osofr already committed the changes related to .from. Is there anything else needed to keep compatibility with igraph?

@maelle
Copy link
Contributor Author

maelle commented Oct 7, 2024

@fkgruber yes, submitting this version to CRAN so that when igraph hits CRAN, your package isn't broken. Thanks a lot for your help.

@fkgruber
Copy link

fkgruber commented Oct 7, 2024

@osofr I will submit the current master version to CRAN

@fkgruber
Copy link

fkgruber commented Oct 7, 2024

@fkgruber yes, submitting this version to CRAN so that when igraph hits CRAN, your package isn't broken. Thanks a lot for your help.

When are you plannig to submit to CRAN?

@maelle
Copy link
Contributor Author

maelle commented Oct 7, 2024

we're working on it this week cc @krlmlr

@maelle
Copy link
Contributor Author

maelle commented Oct 7, 2024

so, the sooner you submit yours the better. I'm sorry I wasn't more explicit when I made this PR this summer!

@fkgruber
Copy link

fkgruber commented Nov 1, 2024

A new version of simcausal has been published:
https://cran.r-project.org/web/packages/simcausal/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants