Skip to content

Conversation

EduFrazao
Copy link
Collaborator

Changes

  • Created alternative implementation of SQLite Value Wrappers using regular Structs and Enums
  • Converters to/from JSI Objects
  • Regular executeSQL call switched to this implementation without any noticiable performance loss
  • Implemented asyncExecuteSQL using JS Thread exclusivelly to convert data structures from parameters and reponses.
  • Tested with more than 100 concurrent fetch queries and thousands of inserted rows using asyncLoadSQL File too.

@ospfranco
Copy link
Owner

ospfranco commented Mar 14, 2022

This is great Edu, I wanted to avoid the wrapper struct, but now that I see the code is not that bad and it looks better than fumbling around with type names of std::any.

I would still like to rename a lot of the classes and separate the files properly, so I will just merge your sub-branch and then do some internal renaming

Thanks a lot for the hard work!

@ospfranco ospfranco merged commit b73241c into ospfranco:async-callback-threads Mar 14, 2022
@EduFrazao
Copy link
Collaborator Author

This is great Edu, I really to avoid the wrapper struct, but now that I see the code is not that bad and it looks better than fumbling around with type names of std::any.

I would still like to rename a lot of the classes and separate the files properly, so I will just merge your sub-branch and then do some internal renaming

Thanks a lot for the hard work!

Very nice @ospfranco . When you finish your changes, I will try to create the Async version of execSQLBatch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants