Style improvements for the MOI wrapper #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
changed the title
blegat
reviewed
Jun 30, 2022
| using LinearAlgebra: rmul! | ||
| import LinearAlgebra | ||
| import MathOptInterface | ||
| import SparseArrays |
There was a problem hiding this comment.
I prefer importing stdlib first, maybe this could be in the style guide. In general, I even load any dependency first so I do some sort of topological sort
blegat
reviewed
Jun 30, 2022
| lower(::MOI.Nonpositives, i::Int) = -Inf | ||
| upper(::MOI.Zeros, i::Int) = 0.0 | ||
| upper(::MOI.Nonnegatives, i::Int) = Inf | ||
| upper(::MOI.Nonpositives, i::Int) = 0.0 | ||
|
|
||
| # TODO: just use ∈ on 0.7 (allocates on 0.6): |
There was a problem hiding this comment.
This function can be removed according to this comment
blegat
reviewed
Jun 30, 2022
|
what was missing on this one? |
|
I think a rebase should be enough my comments were pretty minor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts to tidy up the MOI wrapper.
I've tried to keep this fairly surface level. I haven't re-arranged any code blocks to keep the diff easier to read. I'll do that in another PR.