Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type configurations #5

Merged
merged 4 commits into from
Jul 19, 2018
Merged

type configurations #5

merged 4 commits into from
Jul 19, 2018

Conversation

goulart-paul
Copy link
Collaborator

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 19, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@goulart-paul goulart-paul requested a review from bstellato July 19, 2018 11:26
@coveralls
Copy link

coveralls commented Jul 19, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 60

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 52: 0.0%
Covered Lines: 82
Relevant Lines: 82
💛 - Coveralls

bstellato
bstellato approved these changes Jul 19, 2018
View reviewed changes
Copy link
Collaborator

@bstellato bstellato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I like the new definition and it seems much neater than before.

@bstellato bstellato merged commit 8a1370c into master Jul 19, 2018
@goulart-paul goulart-paul deleted the type_config branch July 19, 2018 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstellato bstellato bstellato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goulart-paul @CLAassistant @coveralls @bstellato