Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CMake version to avoid CMP0048 warning #89

Merged
merged 4 commits into from
Mar 10, 2020
Merged

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Mar 9, 2020

This bumps the minimum CMake version to 3.0.2, which is the minimum supported by ROS Kinetic and new enough to default to the NEW behavior of CMP0048. This avoids a CMake warning when building and testing this package in Debian Buster and Ubuntu Focal.

ros/catkin#1052

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz requested a review from wjwwood March 9, 2020 22:41
@sloretz sloretz self-assigned this Mar 9, 2020
@sloretz sloretz mentioned this pull request Mar 9, 2020
@wjwwood
Copy link
Member

wjwwood commented Mar 10, 2020

Sorry for taking over your pr to fix CI. There's still an issue with one of the tests timing out (seems flaky), but I'll fix that up later.

@wjwwood wjwwood merged commit d4cc2a0 into master Mar 10, 2020
@wjwwood wjwwood deleted the sloretz/cmp0048 branch March 10, 2020 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants