Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gazebo 11] Added profiler to gazebo::rendering and gzclient #2837

Merged
merged 5 commits into from
Oct 2, 2020
Merged

[Gazebo 11] Added profiler to gazebo::rendering and gzclient #2837

merged 5 commits into from
Oct 2, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 31, 2020

Added profiler to gazebo::rendering

Selección_054

Signed-off-by: ahcorde ahcorde@gmail.com

@ahcorde ahcorde added enhancement New feature or request 11 Gazebo 11 labels Aug 31, 2020
@ahcorde ahcorde self-assigned this Aug 31, 2020
mjcarroll
mjcarroll requested changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there may be a misunderstanding in the different IGN_PROFILE invocations. More notes added below.

gazebo/rendering/Camera.cc Outdated Show resolved Hide resolved
@ahcorde
Added profiler to gazebo::rendering
f1cbb7e 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde force-pushed the ahcorde/gz11/profiler/rendering branch from 686275d to f1cbb7e Compare September 16, 2020 08:55
@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 16, 2020

@mjcarroll, I have reduced the call stacks.

@iche033
Copy link
Contributor

iche033 commented Sep 18, 2020

do you need to add a IGN_PROFILE_THREAD_NAME for gzclient? for example, I don't see the profiling points from LaserVisual, UserCamera, WrenchVisual, etc show up in the remotery graphs. Do you see them?

@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 28, 2020

@iche033 I can't see the call IGN_PROFILE_THREAD_NAME("gzclient")

@chapulina
Copy link
Contributor

I can't see the call IGN_PROFILE_THREAD_NAME("gzclient")

I think we should add one, analogous to:

https://github.com/osrf/gazebo/blob/458bbee3d8a3f5b4cb413d4ad549fb5891979790/gazebo/Server.cc#L642

Maybe somewhere in gui/main.cc or gui/GuiIface.cc

@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 29, 2020

We are not profiling the interface (for now). The thread is not even in the interface.

chapulina
chapulina reviewed Sep 29, 2020
View reviewed changes
gazebo/rendering/ApplyWrenchVisual.cc Show resolved Hide resolved
gazebo/rendering/MarkerVisual.cc Outdated Show resolved Hide resolved
gazebo/sensors/CameraSensor.cc Outdated Show resolved Hide resolved
gazebo/sensors/GpuRaySensor.cc Outdated Show resolved Hide resolved
gazebo/sensors/MultiCameraSensor.cc Outdated Show resolved Hide resolved
@chapulina chapulina mentioned this pull request Sep 30, 2020
Merged
@chapulina
Copy link
Contributor

See #2849 for profiling gzclient

@chapulina chapulina mentioned this pull request Sep 30, 2020
Merged
@ahcorde
Added feedback
7349c99 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@chapulina @iche033
Profile gzclient (#2849)
f1730dd 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>

Co-authored-by: Ian Chen <ichen@osrfoundation.org>
@chapulina chapulina mentioned this pull request Sep 30, 2020
Merged
@chapulina
Copy link
Contributor

@osrf-jenkins run tests again

@chapulina
Copy link
Contributor

We ran some Ubuntu CI just for this branch in Build Status and I don't see any new warnings or test failures.

There are 39 test failures, all flaky / known:

    EXAMPLE_examples_build.test_ran
    INTEGRATION_joint_controller.test_ran
    PhysicsEngines/JointForceTorqueTest.GetForceTorqueWithAppliedForce/3
    PhysicsEngines/JointForceTorqueTest.GetForceTorqueWithAppliedForceReset/3
    INTEGRATION_joint_spawn.test_ran
    PhysicsEngines/JointTest.SpringDamperTest/0
    PhysicsEngines/JointTest.SpringDamperTest/2
    INTEGRATION_joint_universal.test_ran
    INTEGRATION_laser.test_ran
    INTEGRATION_model_editor_undo.test_ran
    INTEGRATION_physics.test_ran
    INTEGRATION_physics_collision.test_ran
    PhysicsEngines/PhysicsFrictionTest.FrictionDemo/3
    INTEGRATION_physics_msgs.test_ran
    PhysicsEngines/Pioneer2dx.StraightLine/1
    PluginTest.ModelExceptionConstructor
    PluginTest.ModelExceptionInit
    PluginTest.ModelExceptionLoad
    PluginInterface.LoadParams
    INTEGRATION_sdf_frame_semantics.test_ran
    INTEGRATION_view_angle.test_ran
    INTEGRATION_world_remove.test_ran
    INTEGRATION_world_reset.test_ran
    Issue1208Test.Reset
    UNIT_AltimeterSensor_TEST.test_ran
    UNIT_ApplyWrenchVisual_TEST.test_ran
    UNIT_DepthCameraSensor_TEST.test_ran
    JointInspector_TEST.AppliedSignal
    UNIT_LaserView_TEST.test_ran
    UNIT_MagnetometerSensor_TEST.test_ran
    ModelData_TEST.BoundingCollision
    UNIT_PlotCurve_TEST.test_ran
    UNIT_RaySensor_TEST.test_ran
    UNIT_SimpleTrackedVehiclePlugin_TEST.test_ran
    UNIT_SplashScreen_TEST.test_ran
    UNIT_WheelTrackedVehiclePlugin_TEST.test_ran
    UNIT_WirelessTransmitter_TEST.test_ran
    UNIT_WrenchVisual_TEST.test_ran
    gzTest.SDF

@chapulina chapulina merged commit 10863ff into gazebo11 Oct 2, 2020
@chapulina chapulina deleted the ahcorde/gz11/profiler/rendering branch October 2, 2020 01:22
@chapulina chapulina changed the title [Gazebo 11] Added profiler to gazebo::rendering [Gazebo 11] Added profiler to gazebo::rendering and gzclient Oct 2, 2020
chapulina
chapulina reviewed Oct 2, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to approve before merging ✔️

@chapulina chapulina mentioned this pull request Oct 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina left review comments

@mjcarroll mjcarroll mjcarroll approved these changes

@iche033 iche033 Awaiting requested review from iche033

Assignees

@ahcorde ahcorde

Labels
11 Gazebo 11 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahcorde @iche033 @chapulina @mjcarroll