Add slip values for individual wheels #3082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
ahcorde
reviewed
Sep 20, 2021
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
jacobperron
approved these changes
Sep 20, 2021
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
the code looks good, but the Ubuntu build failed due to the build machine running out of disk space. I made some very small changes in dd43922 in order to restart CI. I'll approve once CI looks ok |
|
After this gets merged, I should probably port this to ignition as well. |
|
CI looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add a functionality to add slip values to individual wheels
Downstream PR: ros-simulation/gazebo_ros_pkgs#1312
Signed-off-by: Aditya Pande aditya050995@gmail.com