Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing C++ Compile Version #76

Merged
merged 23 commits into from
Mar 18, 2023
Merged

Changing C++ Compile Version #76

merged 23 commits into from
Mar 18, 2023

Conversation

CursedRock17
Copy link
Contributor

This is a small pull request directly related to issue #75 that will update the compiler from compiling with standard C++11 to C++17, which should resolve small errors on MacOS arm64 as a guarantee that std::variant works. This change would also require a similar update the CXX version in the performance_test_fixture package as mentioned in the above issue.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I left a question and a couple of small issues in my review.

osrf_testing_tools_cpp/CMakeLists.txt Outdated Show resolved Hide resolved
test_osrf_testing_tools_cpp/CMakeLists.txt Outdated Show resolved Hide resolved
osrf_testing_tools_cpp/src/memory_tools/CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette requested a review from gbiggs as a code owner March 8, 2023 16:25
@clalancette clalancette changed the base branch from master to rolling March 8, 2023 21:56
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 40c6589 into osrf:rolling Mar 18, 2023
@FantasticRhythm
Copy link

FantasticRhythm commented May 23, 2023

after I excuted

colcon build

followed some tutorials

I got some problem with it

Summary: 99 packages finished [56.3s]
1 package failed: performance_test_fixture
9 packages aborted: ament_index_cpp launch_testing_ament_cmake mimick_vendor rosidl_parser rttest rviz_ogre_vendor tlsf tracetools urdf_parser_plugin
31 packages had stderr output: ament_clang_format ament_clang_tidy ament_copyright ament_cppcheck ament_cpplint ament_flake8 ament_index_python ament_lint ament_lint_cmake ament_mypy ament_package ament_pclint ament_pep257 ament_pycodestyle ament_pyflakes ament_uncrustify ament_xmllint domain_coordinator iceoryx_utils launch launch_testing launch_xml launch_yaml osrf_pycommon osrf_testing_tools_cpp performance_test_fixture rosidl_cli rpyutils rviz_ogre_vendor tracetools_read tracetools_trace
196 packages not processed

So, how could I change the c++ complie Version when I build the ROS2-galactic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants