Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 rollback and use new roslib #1

Closed
wants to merge 2 commits into from

Conversation

mvollrath
Copy link

Fixes Polymer 1 support and roslib version.

@mvollrath
Copy link
Author

I need to fix this, something about the rollback commit didn't jive.

@mvollrath
Copy link
Author

That's better.

Copy link
Collaborator

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, so just to recap (please correct me if I'm wrong): we are updating ros-rviz to depend on ros3djs#1.0.0(to be released), which in turn depends on roslib#1.0.0; therefore we need ros-rviz's dependencies to upgrade the dependency on roslib as well.

The dependency chain will end up being something like this:

ros-rviz --> ros3djs#1.0.0 --> roslib#1.0.0
ros-rviz --> ros-websocket#3.x --> roslib#1.0.0
ros-rviz --> ros-service#2.x --> ros-websocket#3.x --> roslib#1.0.0

So the rollback here is because we need to update roslib but at version 3.x because of Polymer's required version right? If that's the case perhaps I'd make a branch from the latest 3.x patch, update roslib and make a new tag instead of rolling back to previous code on the master branch. Then, ros-service and ros-rviz should depend on the new tag.
Does that make sense?

@mvollrath
Copy link
Author

Sounds good, that's what I'd do if I had write access 👍

@jubeira
Copy link
Collaborator

jubeira commented Feb 1, 2019

Sounds good, that's what I'd do if I had write access +1

Maybe @chapulina can make the magic happen 😬

@chapulina
Copy link

Created branch polymer1/2 for the lack of a better name. Feel free to make a new PR targeting that branch, and it may be worth it adding a couple lines to the README explaining how the branches are related to the tagged versions.

@mvollrath mvollrath closed this Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants