Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support humble and iron #13

Merged
merged 3 commits into from
Aug 3, 2023
Merged

support humble and iron #13

merged 3 commits into from
Aug 3, 2023

Conversation

koonpeng
Copy link
Member

@koonpeng koonpeng commented Aug 3, 2023

drop foxy and galactic

@koonpeng
add iron ci
5ad0f23 
Signed-off-by: Teo Koon Peng <koonpeng@google.com>
@koonpeng
cleanup foxy code paths
ded9ef7 
Signed-off-by: Teo Koon Peng <koonpeng@google.com>
@koonpeng
print warning when running with unsupported distro
2d55e8b 
Signed-off-by: Teo Koon Peng <koonpeng@google.com>
@koonpeng koonpeng requested a review from Yadunund August 3, 2023 07:29
Yadunund
Yadunund approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd say no harm in throwing 'rolling' as a supported distro either

@koonpeng koonpeng merged commit 5436a76 into main Aug 3, 2023
2 checks passed
@koonpeng koonpeng deleted the kp/support-humble-iron branch August 3, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yadunund Yadunund Yadunund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koonpeng @Yadunund