Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cuda support to images #126

Merged
merged 26 commits into from
Jul 14, 2022
Merged

add cuda support to images #126

merged 26 commits into from
Jul 14, 2022

Conversation

tfoote
Copy link
Collaborator

@tfoote tfoote commented Mar 12, 2021

Currently a draft proof of concept. This will be revised to be more generic. But this should help with visiblity.

@tfoote tfoote self-assigned this Mar 12, 2021
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #126 (21336f9) into master (4f9f6d7) will decrease coverage by 2.93%.
The diff coverage is 31.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   82.72%   79.78%   -2.94%     
==========================================
  Files           7        7              
  Lines         625      663      +38     
==========================================
+ Hits          517      529      +12     
- Misses        108      134      +26
Impacted Files Coverage Δ
src/rocker/nvidia_extension.py 74.38% <31.57%> (-19.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f9f6d7...21336f9. Read the comment docs.

@M1chaelM M1chaelM mentioned this pull request Jul 27, 2021
Closed
@woensug-choi woensug-choi mentioned this pull request Jul 30, 2021
Closed
@woensug-choi woensug-choi mentioned this pull request Aug 13, 2021
Open
@tfoote tfoote mentioned this pull request Mar 8, 2022
Closed
@tfoote tfoote added the nvidia Connected to the nvidia extension label Mar 9, 2022
@tfoote tfoote mentioned this pull request Jul 5, 2022
Merged
woensug-choi and others added 15 commits July 7, 2022 16:40
@woensug-choi @tfoote
cuda-dev
f342de2
@woensug-choi @tfoote
New Repository Key
3f554dd
@woensug-choi @tfoote
extend capability
23897ec
@woensug-choi @tfoote
remove duplicate .list entries
03ada63
@woensug-choi @tfoote
Package manger installation
034685c
@woensug-choi @tfoote
minor fix
2061aa2
@tfoote
remove elements conflicting with --nvidia option
369106a 
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@tfoote
slight update to docs and supported versions
218b54b 
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@tfoote
Update instructions to follow much more closely the NVIDIA guidance f…
2898af3 
…or installation

Signed-off-by: Tully Foote <tfoote@osrfoundation.org>

# Installation instructions from NVIDIA:
# https://developer.nvidia.com/cuda-downloads?target_os=Linux&target_arch=x86_64&Distribution=Debian&target_version=11&target_type=deb_network
# https://developer.nvidia.com/cuda-downloads?target_os=Linux&target_arch=x86_64&Distribution=Ubuntu&target_version=22.04&target_type=deb_network
@tfoote
abstract keyid out of docker file
42ecaa1 
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@tfoote
fix alphabetization
3966e06 
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@tfoote
enable non-free on debian
1b38987 
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@tfoote
remove old dist-upgrade from debugging
0cee32f 
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@tfoote
clean up contrib and non-free addition
a8fb887 
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@tfoote
add very basic tests
c588e25 
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@tfoote
builds passing
652fba6 
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@tfoote tfoote mentioned this pull request Jul 8, 2022
Closed
@tfoote
tests passing for cuda
60ebb8c 
They are very slow but I think that's going to be the nature of them for this capability. It takes some 9GB of space. That won't be quick any way you slice it.

Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@woensug-choi
Copy link
Contributor

I've tried with and without nvidia-cuda-dev installation block. Both worked for me. No need to include nvidia-cuda-dev for pre-caching purpose.

@tfoote
remove unnecessary packages
b912316 
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@tfoote
change test executable
07b35d1 
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@tfoote
rename to cuda instead of cuda_dev
4f3a755 
cuda_dev is in another package which is available from the system installer

Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@tfoote
Copy link
Collaborator Author

tfoote commented Jul 12, 2022

Great thanks for the testing. I cleaned that stanza out of the Dockerfile. And I tweaked the name to reflect that it's just Cuda now not cuda-dev. And I tried a fix for the test to get it to pass on presumably non-nvidia hardware in CI.

@tfoote tfoote marked this pull request as ready for review July 12, 2022 06:56
@tfoote
fix cuda snippet name
8cde65f 
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@tfoote
test env_subs for cuda directly
4e1d63a 
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@tfoote
using dpkg query to test installation of cuda package
d0bd3b0 
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@tfoote
unpacking test loop
6ac54dc 
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@tfoote
I think that the test_cuda doesn't work without nvida hardware
2a7b0bd 
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@tfoote
double exclude
817461e 
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@woensug-choi
Copy link
Contributor

817461e includes all that I needed. Now, the image has nvcc and all other bin files for the development environment of the Cuda library. Tested with the multibeam sonar https://field-robotics-lab.github.io/dave.doc/contents/dave_sensors/Multibeam-Forward-Looking-Sonar/

@tfoote tfoote merged commit 6b5eae2 into master Jul 14, 2022
@tfoote tfoote deleted the cuda branch July 14, 2022 23:33
woensug-choi added a commit to HonuRobotics/dockwater that referenced this pull request Jul 20, 2022
@woensug-choi
change cuda-dev flag to cuda
e776149 
osrf/rocker#126
@woensug-choi
Copy link
Contributor

Something happend??? I don't see cuda flag in main branch anymore...

@woensug-choi woensug-choi mentioned this pull request Nov 30, 2022
Merged
@tfoote tfoote mentioned this pull request Jun 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tfoote tfoote

Labels
nvidia Connected to the nvidia extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tfoote @woensug-choi