Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added --name argument #94

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Added --name argument #94

merged 1 commit into from
Jul 20, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jul 9, 2020

Added the argument --name to be able to identify easily the docker

Signed-off-by: ahcorde ahcorde@gmail.com

@ahcorde
Added --name argument
ebfc524 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the enhancement New feature or request label Jul 9, 2020
@ahcorde ahcorde requested a review from tfoote July 9, 2020 08:50
@ahcorde ahcorde self-assigned this Jul 9, 2020
@codecov
Copy link

codecov bot commented Jul 9, 2020 •
edited
Loading

Codecov Report

Merging #94 into master will increase coverage by 0.36%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   86.70%   87.06%   +0.36%     
==========================================
  Files           7        7              
  Lines         564      580      +16     
==========================================
+ Hits          489      505      +16     
  Misses         75       75
Impacted Files Coverage Δ
src/rocker/extensions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0821123...ebfc524. Read the comment docs.

tfoote
tfoote approved these changes Jul 20, 2020
View reviewed changes
Copy link
Collaborator

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is good to be able to pass through.

@tfoote tfoote merged commit 019a543 into master Jul 20, 2020
@tfoote tfoote deleted the ahcorde/argument/name branch July 20, 2020 22:21
@tfoote tfoote mentioned this pull request Jul 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

Assignees

@ahcorde ahcorde

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @tfoote