-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: Minor stylistic changes, add documentation links #243
README: Minor stylistic changes, add documentation links #243
Conversation
What is the review policy for this repo? When do I squash? (I really like to make sure my commits are curated, esp. now that BitBucket is no longer being used.) |
We're still figuring these things out internally. Suggestions are very welcome. |
I like the ROS2 guidelines (when using plain vanilla GitHub review), which is to always have fast-forward pushes for review, but then curate commits at the end, possibly after approval. Would that work for you? |
Ooh, also, @scpeters and @azeey and I may try out Reviewable (example draft PR here: gazebosim/sdf_tutorials#3). This is perhaps not actionable now, but I could let you know how that goes for us? |
That sounds reasonable to me, we'll discuss this as a team next week.
We're also planning to discuss this. My main concern is the recommendation to not mix the GitHub and Reviewable interfaces. Do you have any experience mixing both? The entire team at Open Robotics should be able to open and review SDFormat PRs. We should also strive to have a consistent workflow for the entire Ignition family. So it sounds like we either use Reviewable for all projects or none. |
Sounds good. For this PR, I will wait for Approval, then curate my commits.
We just tried it out here: gazebosim/sdf_tutorials#3 (review) The main issue we've had is mixing the request of review between GitHub (assigning reviewers in the sidebar) vs Reviewable ( So overall, the mixing between GitHub and Reviewable is not the most convenient, but may be workable. Understandably, this may not work for y'all, but I would recommend people taking it out for a test run. It's easy to point Reviewable to a PR to try it out on. [*] We also have the following completion script, so it's unclear if this is due to our custom completion script (meant to handle labels and such): |
Are there any action items remaining here? |
Signed-off-by: Eric Cousineau <eric.cousineau@tri.global>
Signed-off-by: Eric Cousineau <eric.cousineau@tri.global>
ba7a967
to
5ac89e9
Compare
Squashed to two curated commits |
And thanks! |
sudo make [un]install
- it's a Bad Idea™