-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sky DOM #397
Add Sky DOM #397
Conversation
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Codecov Report
@@ Coverage Diff @@
## sdf10 #397 +/- ##
==========================================
+ Coverage 87.36% 87.50% +0.14%
==========================================
Files 60 61 +1
Lines 9219 9325 +106
==========================================
+ Hits 8054 8160 +106
Misses 1165 1165
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me, I just have some minor comments.
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. But since this is going into a released branch, how about we wait for the ign-gazebo
integration to be up for review before merging? This way we can be sure we didn't overlook any aspects of the API.
yep sounds good |
The |
@iche033, can we merge this and open some backports as needed? |
* add sky dom Signed-off-by: Ian Chen <ichen@osrfoundation.org> * feedback changes Signed-off-by: Ian Chen <ichen@osrfoundation.org> * move sdf element check Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
* add sky dom Signed-off-by: Ian Chen <ichen@osrfoundation.org> * feedback changes Signed-off-by: Ian Chen <ichen@osrfoundation.org> * move sdf element check Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
* add sky dom Signed-off-by: Ian Chen <ichen@osrfoundation.org> * feedback changes Signed-off-by: Ian Chen <ichen@osrfoundation.org> * move sdf element check Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
* add sky dom Signed-off-by: Ian Chen <ichen@osrfoundation.org> * feedback changes Signed-off-by: Ian Chen <ichen@osrfoundation.org> * move sdf element check Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Add Sky DOM and tests
Signed-off-by: Ian Chen ichen@osrfoundation.org