Add Sky DOM #397
Merged
Add Sky DOM #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Codecov Report
@@ Coverage Diff @@
## sdf10 #397 +/- ##
==========================================
+ Coverage 87.36% 87.50% +0.14%
==========================================
Files 60 61 +1
Lines 9219 9325 +106
==========================================
+ Hits 8054 8160 +106
Misses 1165 1165
Continue to review full report at Codecov.
|
chapulina
reviewed
Oct 27, 2020
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
chapulina
approved these changes
Oct 29, 2020
|
yep sounds good |
|
The |
|
@iche033, can we merge this and open some backports as needed? |
iche033
added a commit
that referenced
this pull request
Nov 17, 2020
* add sky dom Signed-off-by: Ian Chen <ichen@osrfoundation.org> * feedback changes Signed-off-by: Ian Chen <ichen@osrfoundation.org> * move sdf element check Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Merged
scpeters
added a commit
that referenced
this pull request
Nov 25, 2020
azeey
pushed a commit
to azeey/sdformat
that referenced
this pull request
Dec 9, 2020
* add sky dom Signed-off-by: Ian Chen <ichen@osrfoundation.org> * feedback changes Signed-off-by: Ian Chen <ichen@osrfoundation.org> * move sdf element check Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
brawner
pushed a commit
that referenced
this pull request
Dec 11, 2020
* add sky dom Signed-off-by: Ian Chen <ichen@osrfoundation.org> * feedback changes Signed-off-by: Ian Chen <ichen@osrfoundation.org> * move sdf element check Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
brawner
pushed a commit
that referenced
this pull request
Jan 9, 2021
* add sky dom Signed-off-by: Ian Chen <ichen@osrfoundation.org> * feedback changes Signed-off-by: Ian Chen <ichen@osrfoundation.org> * move sdf element check Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Sky DOM and tests
Signed-off-by: Ian Chen ichen@osrfoundation.org