-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Particle emitter #528
Particle emitter #528
Conversation
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Did you mean to target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are a few compile warnings on windows:
https://build.osrfoundation.org/job/sdformat-ci-pr_any-windows7-amd64/2049/msbuild/
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed very minor tweaks in 64ffdd2. It looks good to me besides the branch suggestion!
Thanks, changed to the |
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Fixed in 944e130, |
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
I noticed that the Edit: I thought this was targetting main/sdf11. It makes sense that it wasn't added to 1.8 in this PR. |
🎉 New feature
Summary
Adds
<particle_emitter>
as a child element of<link>
. The values contained within the particle emitter come from the Ignition Gazebo Particle Emitter system.Test it
This is part of a series of pull requests designed to support particle emitter in gz3d.
See also:
Addedparticle_emitter
vector message gz-msgs#149Checklist
sh tools/code_check.sh
)another open pull request
to support the maintainers
Note to maintainers: Remember to use Squash-Merge