Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle emitter #528

Merged
merged 8 commits into from
Apr 6, 2021
Merged

Particle emitter #528

merged 8 commits into from
Apr 6, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Mar 30, 2021

🎉 New feature

Summary

Adds <particle_emitter> as a child element of <link>. The values contained within the particle emitter come from the Ignition Gazebo Particle Emitter system.

Test it

This is part of a series of pull requests designed to support particle emitter in gz3d.
See also:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Code check passed (In source directory, run sh tools/code_check.sh)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review
    another open pull request
    to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Nate Koenig added 4 commits March 26, 2021 15:28
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Mar 30, 2021
@chapulina
Copy link
Contributor

Did you mean to target ign-gazebo4 (Dome)?

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sdf/1.7/particle_emitter.sdf Outdated Show resolved Hide resolved
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed very minor tweaks in 64ffdd2. It looks good to me besides the branch suggestion!

@nkoenig nkoenig changed the base branch from main to sdf10 April 5, 2021 16:16
@nkoenig
Copy link
Contributor Author

nkoenig commented Apr 5, 2021

Did you mean to target ign-gazebo4 (Dome)?

Thanks, changed to the sdf10 branch.

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig
Copy link
Contributor Author

nkoenig commented Apr 5, 2021

there are a few compile warnings on windows:
https://build.osrfoundation.org/job/sdformat-ci-pr_any-windows7-amd64/2049/msbuild/

Fixed in 944e130,

Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig merged commit dc3d100 into sdf10 Apr 6, 2021
@nkoenig nkoenig deleted the particle_emitter branch April 6, 2021 14:57
@azeey
Copy link
Collaborator

azeey commented Apr 6, 2021

I noticed that the <particle_emitter> tag was added to the 1.6 and 1.7 specs and not the 1.8. I would have expected it to be added to only 1.8 since old versions of libsdformat would not know about <particle_emitter>.

Edit: I thought this was targetting main/sdf11. It makes sense that it wasn't added to 1.8 in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants