Validate supported ecosystems and identifier prefixes in the schema definition #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: ossf#201 Signed-off-by: Andrew Pollock <apollock@google.com>
Alphabetise definitions Signed-off-by: Andrew Pollock <apollock@google.com>
andrewpollock
changed the title
Because some ecosystems use the "colon" notation, we have to use a regex for validation purposes instead, unfortunately. Signed-off-by: Andrew Pollock <apollock@google.com>
(rightly or wrongly) Signed-off-by: Andrew Pollock <apollock@google.com>
oliverchang
reviewed
Jun 7, 2024
| "type": "string", | ||
| "title": "Currently supported ecosystems", | ||
| "description": "These ecosystems are also documented at https://ossf.github.io/osv-schema/#affectedpackage-field", | ||
| "pattern": "^(AlmaLinux|Alpine|Android|Bioconductor|Bitnami|ConanCenter|CRAN|crates.io|Debian|GHC|GitHub Actions|GIT|Go|Hackage|Hex|Linux|Maven|npm|NuGet|OSS-Fuzz|Packagist|Photon OS|Pub|PyPI|Rocky Linux|RubyGems|SwiftURL|Ubuntu)(:[[:digit:]]+)?" |
There was a problem hiding this comment.
Does this regex support periods after the : bit? e.g. Debian:3.1 ?
There was a problem hiding this comment.
Any periods as per your example fall outside of the regex as currently defined, so strings as per your example pass validation:
$ cat /tmp/osv-vulnerabilities/Debian/DTSA-99-1.json | gron | grep ecosystem
json.affected[0].package.ecosystem = "Debian:5.0";
$ ~/go/bin/jv ~/gosst/osv/osv-schema/validation/schema.json /tmp/osv-vulnerabilities/Debian/DTSA-99-1.json
$ echo $?
0
oliverchang
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #201