Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check information in README.md and other docs should be programmatically generated from checks.md #898

Open
laurentsimon opened this issue Aug 24, 2021 · 8 comments
Labels
help wanted Community contributions welcome, maintainers supportive of idea but not a high priority kind/docs Improvements or additions to documentation

Comments

@laurentsimon
Copy link
Contributor

laurentsimon commented Aug 24, 2021

An internal team complained that the description in https://github.com/ossf/scorecard#scorecard-checks is different from those in checks.md (Packaging check)

We should pull all the doc for checks from checks.yaml and generate the section of the README programatically. We now have a short field in the checks.md that we may be able to re-use (does not support clickable links, though).

More generally, anywhere we refer to checks, we should generate that programatically.

@laurentsimon laurentsimon added the kind/bug Something isn't working label Aug 24, 2021
@laurentsimon laurentsimon changed the title BUG: check description in README and checks.md out of sync BUG: check information in README.md and other docs should be programmatically generated from checks.md Aug 24, 2021
@laurentsimon
Copy link
Contributor Author

note that in checks/* (registerCheck()) we could also retrieve the check names from the yaml file

@laurentsimon
Copy link
Contributor Author

the run examples should also be generated programatically.

@naveensrinivasan
Copy link
Member

the run examples should also be generated programatically.

Can you please explain further on run examples?

@laurentsimon
Copy link
Contributor Author

oops, sorry.. that was vague. Ideally https://github.com/ossf/scorecard#using-repository-url would be generated from a scorecard run to generate the output example. I don't know how feasible this is in practice.

@laurentsimon
Copy link
Contributor Author

laurentsimon commented Sep 8, 2021

another thing we need to fix: We tend to update checks' source code but forget to update the checks' documentation in the same PR. We need to catch this. One idea would be to:

  1. Create a tool that we run during PR validation in a workflow
  2. The tool would check if anything changes under checks/.
    2.1 If something changed under checks/ and the doc was updated, PASS.
    2.2 If something changed under checks/ but the doc was not updated, FAIL, unless the PR is tagged with a label, say no-doc-change-needed. Reviewers can add the label after reviewing the PR.

In addition to the above, we could also add Need doc update in the PR template to inform the reviewer.

WDUT?

@laurentsimon
Copy link
Contributor Author

we can do the same for keep the cron section of the readme up-to-date, by monitoring changes under cron/

@github-actions
Copy link

Stale issue message

@laurentsimon laurentsimon reopened this Dec 30, 2021
@github-actions github-actions bot closed this as completed Jan 7, 2022
@laurentsimon laurentsimon reopened this Jan 7, 2022
@laurentsimon laurentsimon reopened this Jan 18, 2022
@afmarcum afmarcum added kind/docs Improvements or additions to documentation and removed kind/bug Something isn't working labels Feb 5, 2024
@lasomethingsomething
Copy link

Reviewed in community backlog -- would be automatically update docs with explanations about how scorecard works. Impact of not having this is that docs may be different in the Readme vs. the output. Primary value here would be to reduce toil for the maintainers so they no longer have to update docs in two places.

@afmarcum afmarcum changed the title BUG: check information in README.md and other docs should be programmatically generated from checks.md check information in README.md and other docs should be programmatically generated from checks.md Feb 5, 2024
@afmarcum afmarcum added the help wanted Community contributions welcome, maintainers supportive of idea but not a high priority label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Community contributions welcome, maintainers supportive of idea but not a high priority kind/docs Improvements or additions to documentation
Projects
Status: No status
Development

No branches or pull requests

4 participants