-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create BEST_practices_wg_graduation_stage.md #293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but as indicated in our instructions, this PR should also change the status of the TI in the README, otherwise we'll had to do it in another PR.
https://github.com/ossf/tac/blob/main/process/working-group-lifecycle.md#working-group-creation-or-change-of-lifecycle-stage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To align with the other TI graduate requirements for governance docs, can you please add a link in this application?
- [Avishay Balter, Microsoft](https://github.com/balteravishay) - Memory Safety SIG Co-Lead | ||
|
||
|
||
### Governance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a link in here that points to the project governance documents (per the #296 TIs Gives+Gets and updated WG template)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added link to WG charter - https://github.com/ossf/wg-best-practices-os-developers/blob/main/CHARTER.md
PR to recognize BEST WG is "graduated" in lifecycle Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
e037ddd
to
6f9e7d6
Compare
I fixed it for you. :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
4a26190
to
4bcd85a
Compare
added link to wg charter Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks CRob !
5 of 9 TAC members have approved this PR, merging. Congrats on reaching "Graduated" level, BEST WG! |
PR to recognize BEST WG is "graduated" in lifecycle