Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create BEST_practices_wg_graduation_stage.md #293

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Conversation

SecurityCRob
Copy link
Contributor

PR to recognize BEST WG is "graduated" in lifecycle

Copy link
Contributor

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but as indicated in our instructions, this PR should also change the status of the TI in the README, otherwise we'll had to do it in another PR.
https://github.com/ossf/tac/blob/main/process/working-group-lifecycle.md#working-group-creation-or-change-of-lifecycle-stage

Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To align with the other TI graduate requirements for governance docs, can you please add a link in this application?

- [Avishay Balter, Microsoft](https://github.com/balteravishay) - Memory Safety SIG Co-Lead


### Governance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a link in here that points to the project governance documents (per the #296 TIs Gives+Gets and updated WG template)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR to recognize BEST WG is "graduated" in lifecycle

Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
@lehors
Copy link
Contributor

lehors commented Mar 20, 2024

LGTM but as indicated in our instructions, this PR should also change the status of the TI in the README, otherwise we'll had to do it in another PR. https://github.com/ossf/tac/blob/main/process/working-group-lifecycle.md#working-group-creation-or-change-of-lifecycle-stage

I fixed it for you. :-)

Copy link
Contributor

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
added link to wg charter

Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks CRob !

@SecurityCRob
Copy link
Contributor Author

5 of 9 TAC members have approved this PR, merging. Congrats on reaching "Graduated" level, BEST WG!

@SecurityCRob SecurityCRob merged commit 090d7a0 into main Mar 21, 2024
6 of 7 checks passed
@SecurityCRob SecurityCRob deleted the SecurityCRob-patch-1 branch March 21, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants