pull changes from upstream #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per discussion here: https://github.com/twilio/video-quickstart-android#troubleshooting-audio and here: twilio/video-quickstart-android#221 On some devices it may be advisable to disable openSL ES. This PR exposes that functionality.
Function to disable OpenSL ES on Android
Update twiliovideo dependency version
Mention proguard in android instructions
This PR updates the library to support version 2.2 of the Twilio Video library. It does not yet expose any new functionality per-se of v2 of the library; the goal here is feature parity with minimal changes for existing users of the library.
The major user-visible changes are:
* onParticipant{Enabled/Disabled}Track are now broken out into separate events for Audio and Video.
* The track identifier prop type now contains two fields: `participantSid` and `videoTrackSid`. Generally under the hood we try to use sids everywhere as the idenfitier for participants and tracks. This would necessitate a small change in the example, namely in the `onParticipantAddedVideoTrack` handler set:
```
this.setState({
participant,
track,
});
```
and then pass this in as follows:
```
<TwilioVideoParticipantView trackIdentifier={{ participantSid: this.state.participant.sid, videoTrackSid: this.state.track.trackSid }} />
```
This updates the interface to work with Twilio Video v2.1. In addition to a bunch of general cleanup, it updates the events to be more similar to their iOS counterparts. The same user changes needed to get things working on iOS should also work here (namely, the use of Sids to identify everything).
Support on Android for Twilio Video v2
Support Twilio Video 2.2 on iOS
Sorry, my previous PR accidentally omitted to header file changes.
Fix iOS build
On iOS these are promises, but not on Android. Return promises so that users can expect a consistent interface.
Mention installing entirely via podspec, and also mention updating header paths.
* Updates the example. * Removes the android-specific example. Since the two platforms are pretty much in sync now, it doens't make sense to have two separate examples to grok. * Update the example in the readme. * Add in the section in the readme about migrating from 1.x to 2.x.
Update Pod install docs
Updates examples and docs for 2.x
Promisify setLocal{Audio/Video}Enabled on Android
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.31 to 0.7.33. - [Release notes](https://github.com/faisalman/ua-parser-js/releases) - [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md) - [Commits](faisalman/ua-parser-js@0.7.31...0.7.33) --- updated-dependencies: - dependency-name: ua-parser-js dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.31 to 0.7.33. - [Release notes](https://github.com/faisalman/ua-parser-js/releases) - [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md) - [Commits](faisalman/ua-parser-js@0.7.31...0.7.33) --- updated-dependencies: - dependency-name: ua-parser-js dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [debug](https://github.com/debug-js/debug) from 2.6.8 to 2.6.9. - [Release notes](https://github.com/debug-js/debug/releases) - [Changelog](https://github.com/debug-js/debug/blob/2.6.9/CHANGELOG.md) - [Commits](debug-js/debug@2.6.8...2.6.9) --- updated-dependencies: - dependency-name: debug dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat(config-plugin): wip on implementing expo config plugin * fix(config-plugin): add missing peerDependency on expo-build-properties * feat(config-plugin): improve typings for plugin * feat(config-plugin): rename entrypoint to index, add 'build' folder * docs(config-plugin): add docs on how to use with Expo in README.md * docs(config-plugin): add missing section about installing expo-build-properties * chore: temporary disable deploymentTarget setup * chore: update build folder
Bumps [qs](https://github.com/ljharb/qs) from 6.7.0 to 6.11.0. - [Release notes](https://github.com/ljharb/qs/releases) - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.7.0...v6.11.0) --- updated-dependencies: - dependency-name: qs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [minimatch](https://github.com/isaacs/minimatch) to 3.1.2 and updates ancestor dependency [gulp](https://github.com/gulpjs/gulp). These dependencies need to be updated together. Updates `minimatch` from 0.2.14 to 3.1.2 - [Release notes](https://github.com/isaacs/minimatch/releases) - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v0.2.14...v3.1.2) Updates `gulp` from 3.9.1 to 4.0.2 - [Release notes](https://github.com/gulpjs/gulp/releases) - [Changelog](https://github.com/gulpjs/gulp/blob/master/CHANGELOG.md) - [Commits](gulpjs/gulp@v3.9.1...v4.0.2) --- updated-dependencies: - dependency-name: minimatch dependency-type: indirect - dependency-name: gulp dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [lodash.template](https://github.com/lodash/lodash) from 3.6.2 to . - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/commits) --- updated-dependencies: - dependency-name: lodash.template dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* RN-0.73 change Android configs for RN 0.73 compatibility * add back the namespace to AndroidManifest
* Feature: Add setRemoteAudioPlayback to android * remove unnecessary return
When react's set state hook depends on past values, a callback is recommendend
gastonmorixe
force-pushed
the
master
branch
from
6f9e9ae
to
7c3cd06
Compare
gastonmorixe
force-pushed
the
master
branch
from
7c3cd06
to
bce7e78
Compare
Add Star History
PR#716 PR#715 PR#714
Will remove CircleCI next
- `npm --save` is not longer necessary - yarn install from repo now from npm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.