Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SW-4997: Switch from using ROS timer to threads for polling lidar data #139

Merged
merged 2 commits into from
May 17, 2023
Merged

SW-4997: Switch from using ROS timer to threads for polling lidar data #139

merged 2 commits into from
May 17, 2023

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented May 16, 2023 •
edited
Loading

Related Issues & PRs

Summary of Changes

  • Deprecate the use of timers to poll data
  • Specify defaults for non-required params

Validation

  • Existing functionality not affected

@Samahu Samahu added the enhancement New feature or request label May 16, 2023
@Samahu Samahu self-assigned this May 16, 2023
@Samahu Samahu mentioned this pull request May 16, 2023
Merged
@Samahu Samahu changed the title SW-4997: Switch from using ROS timer to threadS for polling data SW-4997: Switch from using ROS timer to threads for polling data May 16, 2023
@Samahu Samahu marked this pull request as ready for review May 17, 2023 16:39
@Samahu Samahu changed the title SW-4997: Switch from using ROS timer to threads for polling data SW-4997: Switch from using ROS timer to threads for polling lidar data May 17, 2023
@Samahu Samahu merged commit 4774e8b into ros2-foxy May 17, 2023
@Samahu Samahu mentioned this pull request May 17, 2023
Closed
@Samahu Samahu deleted the SW-4997-switch-from-using-timers-to-threads-to-poll-the-client-foxy branch May 17, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bexcite bexcite bexcite approved these changes

@twslankard twslankard Awaiting requested review from twslankard

@chrisbayruns chrisbayruns Awaiting requested review from chrisbayruns

Assignees

@Samahu Samahu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Samahu @bexcite