Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SW-4747: update the ros 2 driver(s) to the 20230403 sdk release #94

Merged
merged 6 commits into from
Apr 4, 2023
Merged

SW-4747: update the ros 2 driver(s) to the 20230403 sdk release #94

merged 6 commits into from
Apr 4, 2023

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented Mar 31, 2023 •
edited
Loading

Related Issues & PRs

Summary of Changes

  • Update to the latest sdk release
  • Bring multicast functionality to ROS2 driver(s)
  • Implement a technique to assign proper timestamp when begging packets in the frame are missed.
  • Add frame_id to all published images
  • Fixed a potential issue of time values within generated point clouds that could lead to time value overflow
  • Update README.md

Validation

Launch ouster driver with a sensor and/or recorded bag file and verify it works as expected

@Samahu
Update to the latest ouster sdk +
889aca0 
forward multicast funcitonality + other improvements and fixes
@Samahu Samahu added the enhancement New feature or request label Mar 31, 2023
@Samahu Samahu self-assigned this Mar 31, 2023
@Samahu Samahu marked this pull request as ready for review April 4, 2023 18:38
@Samahu Samahu mentioned this pull request Apr 4, 2023
Merged
@Samahu Samahu merged commit 7a10d2c into ros2 Apr 4, 2023
@Samahu Samahu deleted the SW-4747-update-the-ros-2-driver-to-the-latest-sdk-release branch April 4, 2023 22:42
Samahu added a commit that referenced this pull request Apr 28, 2023
@Samahu
Squashed commit of the following:
b8216e9 
commit c94a581
Author: Ussama Naal <ussama.naal@ouster.io>
Date:   Fri Apr 28 13:31:55 2023 -0700
-    Add a TODO note

commit 33b01cb
Author: Ussama Naal <ussama.naal@ouster.io>
Date:   Fri Apr 28 13:20:09 2023 -0700

    Propagate the parameters to launch files

commit 2991897
Author: Ussama Naal <ussama.naal@ouster.io>
Date:   Fri Apr 28 12:50:00 2023 -0700

    Update ChangeLog and package version

commit d58c186
Author: Ussama Naal <ussama.naal@ouster.io>
Date:   Fri Apr 28 12:40:43 2023 -0700

    Squashed commit of the following:

    commit 6280bfa1178bdee4fe695cb4752efd5ff15279db
    Author: Ussama Naal <ussama.naal@ouster.io>
    Date:   Fri Apr 28 07:54:34 2023 -0700

        Merge branch 'deprecate_tf_prefix'

    commit 35f2fd2
    Author: Guillaume Doisy <guillaume@dexory.com>
    Date:   Mon Apr 3 18:12:44 2023 +0100

        deprecate tf_prefix from os_cloud

commit acbe1fe
Author: Guillaume Doisy <doisyg@users.noreply.github.com>
Date:   Fri Apr 28 20:27:20 2023 +0100

    deprecate tf_prefix from os_cloud (#96)

    Co-authored-by: Guillaume Doisy <guillaume@dexory.com>

commit 175a197
Author: Ussama Naal <606033+Samahu@users.noreply.github.com>
Date:   Wed Apr 19 12:28:13 2023 -0700

    SW-4837: replace the use of ros service to retrieve sensor metadata with latched topics (#102)

    * Working port of latched metadata topic on ros2
    * Update replay and record launch files to providing metadata file an optional parameter
    * Remove extra white space in replay record command
    * Undo changes to the metadata-qos-override
    * minor code syntax improvements
    * Add missing metadata topic when bag file isn't specified
    * Use concise syntax and formatting
    * Reverse logic for easier read
    * Apply node transition if it exists

commit 592e316
Author: Ussama Naal <606033+Samahu@users.noreply.github.com>
Date:   Tue Apr 11 18:18:24 2023 -0700

    Explicity set cxx compile standard if the env isn't (#99)

commit 7a10d2c
Author: Ussama Naal <606033+Samahu@users.noreply.github.com>
Date:   Tue Apr 4 15:42:49 2023 -0700

    SW-4747: update the ros 2 driver(s) to the 20230403 sdk release (#94)

    * Update to the latest ouster sdk
    * Forward multicast funcitonality + Other improvements and fixes
    * Add service_msgs dependency to package.xml
    * Correct sensor_mtp.launch for ros2 launch file format
    * Move to most recent SDK update
    * Declare and fill defaults for mtp paramters + fix uninitialzed compute_to_scan
    * Launch file rename and README corrections

commit fd76cc9
Author: Ussama Naal <ussama.naal@ouster.io>
Date:   Tue Feb 28 20:07:46 2023 -0800

    Remove the duplicate sensor_info object

commit 7da1a96
Merge: 22acf88 2793304
Author: Ussama Naal <606033+Samahu@users.noreply.github.com>
Date:   Mon Feb 20 13:39:46 2023 -0800

    Merge pull request #51 from ouster-lidar/SW-4342-prototype-ros-2-driver

    ROS2 driver MVP (beta release)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kairenw kairenw kairenw approved these changes

@bexcite bexcite Awaiting requested review from bexcite

@twslankard twslankard Awaiting requested review from twslankard

@chrisbayruns chrisbayruns Awaiting requested review from chrisbayruns

Assignees

@Samahu Samahu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Samahu @kairenw