Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding issue #149, I added a
test
property to the options. Set it to true to always show the banner on load (for testing purposes). I didn't update the documentation because that can easily be updated to the way you guys like it.I followed how things are currently done in the code; however, there's some unnecessary assignment going on. You might as well assign the property in
options
straight to the variable in this code:I think the main intent was something like this though:
Also, these variables are global. They're not private. I'm going to go through the code and clean it up.
Additionally, the code needs to be minified... I'm not sure what minifier you used so I didn't do it (it would be nice to have a build script)