Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0DAY vuln #1984

Closed
dreiggy opened this issue Mar 18, 2020 · 19 comments
Closed

0DAY vuln #1984

dreiggy opened this issue Mar 18, 2020 · 19 comments

Comments

@dreiggy
Copy link
Contributor

dreiggy commented Mar 18, 2020

Operating System (OS/VERSION):

Seems ALL

VestaCP Version:

ALL

Installed Software (what you got with the installer):

vestacp backup part

Steps to Reproduce:

https://pentest.blog/vesta-control-panel-second-order-remote-code-execution-0day-step-by-step-analysis/

@ScIT-Raphael
Copy link

There is a fix in our fork for this issue, maybe the devs of vesta would like to have a look: hestiacp/hestiacp@1f56a42

@devsrealm
Copy link

Anyone looking into this?

@Lupul
Copy link

Lupul commented Mar 20, 2020

There is a new thread on the Vesta forum regarding this issue, but still no update yet
https://forum.vestacp.com/viewtopic.php?f=10&t=19714

@dpeca
Copy link
Collaborator

dpeca commented Mar 23, 2020

Here is the fix -> a571254

@serghey-rodin must run build in order to push it on apt and rpm repo.

Before he do it, you can get latest code from github by running:
Updating VestaCP on CentOS from official github repo:

yum install -y git
cd /root
rm -rf /root/vesta
git clone https://github.com/serghey-rodin/vesta.git
yes | cp -rf /root/vesta/* /usr/local/vesta

Updating VestaCP on Debian/Ubuntu from official github repo:

apt install -y git
cd /root
rm -rf /root/vesta
git clone https://github.com/serghey-rodin/vesta.git
cp -rf /root/vesta/* /usr/local/vesta

And I must agree with @ScIT-Raphael , I advised the same thing before 2 years, conf parser function instead of eval is the right fix for all vulnerabilities of this type.

@Barmunksu
Copy link

Barmunksu commented Apr 16, 2020

maybe it's time to create an alternative RPM\APT repo with 0day hot fix? And update readme

@ScIT-Raphael
Copy link

ScIT-Raphael commented Apr 16, 2020

@Barmunksu it would, but also all users would need to change the repository. The only realy save way is to push the deb/rpm packages to the current repository, which also includes an autoupdate function - but @serghey-rodin is the only one with access to it, hopefully he will react...

Otherwise, deb based systems (Ubuntu 16.04/18.04, Debian 8-10) could switch to our fork hestia (https://github.com/hestiacp/hestiacp) or use the patched apt repository of @dpeca (https://github.com/myvesta/vesta), which only supports Debian 10.

@Barmunksu
Copy link

it would, but also all users would need to change the repository.

New users will be safe. And those who really need it, will add a new repository. Just add an important note on the forum and here...

@ScIT-Raphael
Copy link

ScIT-Raphael commented Apr 18, 2020

@Barmunksu I'm not in the position to decide this, also, as I already wrote, I doesnt have enough time to push and manage a second repo beside hestia.

@ahmiq
Copy link

ahmiq commented Apr 26, 2020

@Barmunksu it would, but also all users would need to change the repository. The only realy save way is to push the deb/rpm packages to the current repository, which also includes an autoupdate function - but @serghey-rodin is the only one with access to it, hopefully he will react...

Otherwise, deb based systems (Ubuntu 16.04/18.04, Debian 8-10) could switch to our fork hestia (https://github.com/hestiacp/hestiacp) or use the patched apt repository of @dpeca (https://github.com/myvesta/vesta), which only supports Debian 10.

Can one directly swtich from the official to Hestia or Myvesta Fork without breaking anything? Perhaps a guide would be great for all users. Thanks

@ScIT-Raphael
Copy link

A switch to hestia needs a fresh install, but you can restore your vesta backups using the normal v-restore-user command.

For MyVesta, if you use debian10, it should be possible to "just" switch the repository, probaly @dpeca has more informations.

@Neustradamus
Copy link

@serghey-rodin: Any news about this vulnerability?

Remark: It is possible to move the vesta in a organization with devs?

We need to have changes in current Vesta...

I am ready to do it.

@Neustradamus
Copy link

@dpeca: It is solved?

@ScIT-Raphael
Copy link

They are solved since a long time on the github project, @dpeca has fixed them - but unfortunaly, he can't build the new packages. This can do, as far as I know, only one person, but he doesnt react to anything...

@dpeca
Copy link
Collaborator

dpeca commented Jun 23, 2020

@Neustradamus
Fixed on March 23 - #1984 (comment)

@Neustradamus
Copy link

@dpeca: Sorry but it is good to recall when the ticket is closed and in the release!

It is very important to create a new release with this fix!

@serghey-rodin: It is possible to move this repository in an organization and improve it correctly?
The team work must not be stopped...

Currently, there is a big problem of support and security and the project is dead.

@dpeca, @ScIT-Raphael: I am ready to help at several points...

Who manage the official website and social networks?

@dpeca
Copy link
Collaborator

dpeca commented Jun 23, 2020

I think only @serghey-rodin has access to website and apt/rpm repos.

Fixes are built in HestiaCP and myVesta apt repo the same day we put it on github (March 23).

@asheroto
Copy link

asheroto commented Jul 4, 2020

+1 for adding and apt/rpm repo

Using Debian 9

@asheroto
Copy link

asheroto commented Jul 4, 2020

Before he do it, you can get latest code from github by running:
Updating VestaCP on CentOS from official github repo:

yum install -y git
cd /root
rm -rf /root/vesta
git clone https://github.com/serghey-rodin/vesta.git
yes | cp -rf /root/vesta/* /usr/local/vesta

Updating VestaCP on Debian/Ubuntu from official github repo:

apt install -y git
cd /root
rm -rf /root/vesta
git clone https://github.com/serghey-rodin/vesta.git
cp -rf /root/vesta/* /usr/local/vesta

And I must agree with @ScIT-Raphael , I advised the same thing before 2 years, conf parser function instead of eval is the right fix for all vulnerabilities of this type.

Followed your instructions for Debian (using Debian 9). Still showing version 0.9.8 release 26 after restart? Has the fix not been officially released?

image

@anton-reutov anton-reutov modified the milestones: 0.9.8-24(1), 0.9.8-27 Jul 4, 2020
@dpeca
Copy link
Collaborator

dpeca commented Jul 17, 2020

@asheroto

Followed your instructions for Debian (using Debian 9). Still showing version 0.9.8 release 26 after restart? Has the fix not been officially released?

if you get latest code from github, yes, you have all fixes.
the version number is still 26 because it will be altered when Serghey run the build.
but it's anyway just a versioning number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants