fix: build warnings #2562
Merged
fix: build warnings #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
privatenumber
commented
Apr 5, 2023
| @@ -651,7 +651,6 @@ const exports = { | |||
| setDefaultResultOrder, | |||
| resolve, | |||
| reverse, | |||
| resolve, | |||
There was a problem hiding this comment.
Duplicate export
privatenumber
commented
Apr 5, 2023
| @@ -20,7 +20,6 @@ export class PerformanceNodeTiming { | |||
| export default { | |||
| performance, | |||
| PerformanceEntry, | |||
| PerformanceEntry, | |||
There was a problem hiding this comment.
Duplicate export
privatenumber
commented
Apr 5, 2023
| @@ -38,7 +38,6 @@ var repl = { | |||
| history: [], | |||
| _initialPrompt: "> ", | |||
| terminal: true, | |||
| cursor: 0, | |||
There was a problem hiding this comment.
Duplicate entry.
privatenumber
commented
Apr 5, 2023
| @@ -167,7 +167,7 @@ export async function request( | |||
| if (typeof url === "string") { | |||
| if (query) url = new URL(url); | |||
| } else if (typeof url === "object" && url !== null) { | |||
| if (!url instanceof URL) { | |||
There was a problem hiding this comment.
Bug, treated as (!url) instanceof URL
Closed
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to build with esbuild emitted the following warnings