-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite IO for Bun.file() #7470
Conversation
@@ -0,0 +1,379 @@ | |||
const std = @import("std"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should link to where you got this from (https://github.com/mitchellh/libxev/blob/main/src/heap.zig)
❌ @cirospaciari 11 files with test failures on bun-darwin-x64:
|
❌ @cirospaciari 9 files with test failures on bun-darwin-x64-baseline:
|
❌ @cirospaciari 4 files with test failures on bun-darwin-aarch64:
|
❌ @cirospaciari 2 files with test failures on linux-x64-baseline:
|
❌ @cirospaciari 1 files with test failures on linux-x64:
|
* WIP rewrite IO for Bun.file() * It seems to work on macOS * Update ffi.zig * Handle many more cases * Clarify this more * More comments * [autofix.ci] apply automated fixes * Add empty * Make it work in epoll * fetch fixes + tests fmt --------- Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: cirospaciari <ciro.spaciari@gmail.com>
What does this PR do?
Use epoll instead of io_uring for Bun.file()
Bun.file(path)
) #4798(await Bun.file(...)).text()
crashes on existent but empty files on some filesystems #4603bun run
fails in docker ubuntu: script "build" exited with code 1 (SIGHUP) #5007Probably fixes:
How did you verify your code works?
Existing tests + manual