Rewrite IO for Bun.file()#7470
Merged
Merged
Conversation
paperclover
reviewed
Dec 6, 2023
| @@ -0,0 +1,379 @@ | |||
| const std = @import("std"); | |||
Contributor
There was a problem hiding this comment.
you should link to where you got this from (https://github.com/mitchellh/libxev/blob/main/src/heap.zig)
Contributor
|
❌ @cirospaciari 11 files with test failures on bun-darwin-x64:
|
Contributor
|
❌ @cirospaciari 9 files with test failures on bun-darwin-x64-baseline:
|
Contributor
|
❌ @cirospaciari 4 files with test failures on bun-darwin-aarch64:
|
Contributor
|
❌ @cirospaciari 2 files with test failures on linux-x64-baseline:
|
Contributor
|
❌ @cirospaciari 1 files with test failures on linux-x64:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use epoll instead of io_uring for Bun.file()
Bun.file(path)) #4798(await Bun.file(...)).text()crashes on existent but empty files on some filesystems #4603bun runfails in docker ubuntu: script "build" exited with code 1 (SIGHUP) #5007Probably fixes:
How did you verify your code works?
Existing tests + manual