Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite IO for Bun.file() #7470

Merged
merged 11 commits into from
Dec 7, 2023
Merged

Rewrite IO for Bun.file() #7470

merged 11 commits into from
Dec 7, 2023

Conversation

Jarred-Sumner
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner commented Dec 5, 2023

@@ -0,0 +1,379 @@
const std = @import("std");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should link to where you got this from (https://github.com/mitchellh/libxev/blob/main/src/heap.zig)

@Jarred-Sumner Jarred-Sumner marked this pull request as ready for review December 6, 2023 15:06
Copy link
Contributor

github-actions bot commented Dec 6, 2023

@cirospaciari 11 files with test failures on bun-darwin-x64:

  • test/cli/run/env.test.ts
  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/grpc-js/test-channel-credentials.test.ts
  • test/js/third_party/grpc-js/test-client.test.ts
  • test/js/third_party/grpc-js/test-idle-timer.test.ts
  • test/js/third_party/grpc-js/test-retry.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#3deb58a80f862343748783e2158db3372da1e6c0

Copy link
Contributor

github-actions bot commented Dec 6, 2023

@cirospaciari 9 files with test failures on bun-darwin-x64-baseline:

  • test/cli/run/env.test.ts
  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/prompts/prompts.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#3deb58a80f862343748783e2158db3372da1e6c0

Copy link
Contributor

github-actions bot commented Dec 6, 2023

@cirospaciari 4 files with test failures on bun-darwin-aarch64:

  • test/cli/run/env.test.ts
  • test/cli/run/require-cache.test.ts
  • test/js/web/fetch/body-stream.test.ts
  • test/js/web/worker.test.ts

View test output

#3deb58a80f862343748783e2158db3372da1e6c0

Copy link
Contributor

github-actions bot commented Dec 6, 2023

@cirospaciari 2 files with test failures on linux-x64-baseline:

  • test/cli/run/env.test.ts
  • test/integration/next/default-pages-dir/test/next-build.test.ts

View test output

#3deb58a80f862343748783e2158db3372da1e6c0

Copy link
Contributor

github-actions bot commented Dec 6, 2023

@cirospaciari 1 files with test failures on linux-x64:

  • test/cli/run/env.test.ts

View test output

#3deb58a80f862343748783e2158db3372da1e6c0

@Jarred-Sumner Jarred-Sumner merged commit b1c8ae9 into main Dec 7, 2023
18 of 28 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/rewrite-io-bun-file branch December 7, 2023 02:10
ryoppippi pushed a commit to ryoppippi/bun that referenced this pull request Feb 1, 2024
* WIP rewrite IO for Bun.file()

* It seems to work on macOS

* Update ffi.zig

* Handle many more cases

* Clarify this more

* More comments

* [autofix.ci] apply automated fixes

* Add empty

* Make it work in epoll

* fetch fixes + tests fmt

---------

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: cirospaciari <ciro.spaciari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment