fix: large bunx changes, mostly for better windows support
#9143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @paperdave 1 files with test failures on bun-darwin-aarch64: |
|
❌ @paperdave 3 files with test failures on linux-x64:
|
|
❌ @paperdave 1 files with test failures on linux-x64-baseline: |
|
❌ @paperdave 3 files with test failures on bun-darwin-x64:
|
❌🪟 @paperdave, there are 13 test regressions on Windows x86_64
|
|
another fix done |
dylan-conway
reviewed
Mar 1, 2024
dylan-conway
reviewed
Mar 1, 2024
i am removing this because unreachable here does not do any optimization and unlike in zig we cannot do noreturn.
|
paperclover
changed the title
bunx changes, mostly for better windows support
|
Many test failures to fix first |
| @@ -202,6 +207,21 @@ pub const Shebang = struct { | |||
| return try Shebang.init(line, false); | |||
| } | |||
|
|
|||
| pub fn coerceNodeToBun(self: Shebang, buf: *[32766]u8) Shebang { | |||
|
Assuming the test failures are gone, looks great. |
| _ = nt.NtClose(process.hProcess); | ||
| _ = nt.NtClose(process.hThread); | ||
| _ = nt.NtClose(process.hProcess); | ||
| _ = nt.NtClose(process.hThread); |
There was a problem hiding this comment.
@paperdave was it intentional we close the thread handle only after the process has exited instead of immediately? since this handle is not used, couldn't we close it immediately?
| inline for (.{ 0, 1 }) |attempt_number| iteration: { | ||
| if (dbg) | ||
| debug("lpCommandLine: {}\n", .{fmt16(std.mem.span(spawn_command_line))}); | ||
| const did_process_spawn = k32.CreateProcessW( |
There was a problem hiding this comment.
maybe we should get/set the codepage before & after?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node.exefailed due to not found, then it retries once with bun..bunxfast path tobunx#8918--bun. TODO: verify this closes the following issues on all platforms:Bun isn't respecting shebangs in vite, even with --bun flag #6340Not a bug in Bun.--bun#4974--bunoption beforecreatecommand crashes while--bunaftercreateworks fine #6215--verbosepasses verbose to the package managerstuff like this works now:
