Command as service introduce a break

[mcg-web]

Q	A
Bug report?	yes
Feature request?	no
BC Break report?	no
RFC?	no
Version/Branch	master

After a git bisect it seems that this commit:

5b36835515a6814b66d39b873cb04d36a1854cba is the first bad commit
commit 5b36835515a6814b66d39b873cb04d36a1854cba
Author: Renato Mendes Figueiredo <gh@renatomefi.com.br>
Date:   Mon Oct 16 20:48:58 2017 +0200

    GraphQL Schema Dump command as a service

:040000 040000 807d5809c631d81c73deec7981582211836270e2 2713f31440aec94fa69212686d5d2f8cd159ffad M    Command
:040000 040000 971373f3feb37d353914f67534304b4a738f820e 96e17c1fad65b7feeac8d701a0b3d7dbe0c0d081 M    Resources
:040000 040000 c835fc3824c573b3eacae57d2109046a3f850a82 6497322528b8c4e89df20c375e52acd3fc516ec7 M    Tests

Trigger this error:

▶ tb bin/console cache:clear -vvv


  [GraphQL\Error\InvariantViolation]
  Query fields must not be empty

Thanks to @OwlyCode for the feedback

[renatomefi]

Good catch. I'll try to look into it later!

[renatomefi]

That's a bit tricky, since the commands are now services they load in an early state, so if the user doesn't have all configured for instance it can generate errors:

Exception trace:
 () at /home/renatomefi/Workspace/PHP/graphql/test-debug-bug/vendor/overblog/graphql-bundle/Resolver/TypeResolver.php:56
 Overblog\GraphQLBundle\Resolver\TypeResolver->baseType() at /home/renatomefi/Workspace/PHP/graphql/test-debug-bug/vendor/overblog/graphql-bundle/Resolver/TypeResolver.php:46
 Overblog\GraphQLBundle\Resolver\TypeResolver->string2Type() at /home/renatomefi/Workspace/PHP/graphql/test-debug-bug/vendor/overblog/graphql-bundle/Resolver/TypeResolver.php:32
 Overblog\GraphQLBundle\Resolver\TypeResolver->resolve() at /home/renatomefi/Workspace/PHP/graphql/test-debug-bug/vendor/overblog/graphql-bundle/Definition/Builder/SchemaBuilder.php:31
 Overblog\GraphQLBundle\Definition\Builder\SchemaBuilder->create() at /home/renatomefi/Workspace/PHP/graphql/test-debug-bug/var/cache/dev/srcDevDebugProjectContainer.php:1094
 srcDevDebugProjectContainer->getOverblogGraphql_RequestExecutorService() at /home/renatomefi/Workspace/PHP/graphql/test-debug-bug/vendor/symfony/dependency-injection/Container.php:336
 Symfony\Component\DependencyInjection\Container->get() at /home/renatomefi/Workspace/PHP/graphql/test-debug-bug/var/cache/dev/srcDevDebugProjectContainer.php:942
 srcDevDebugProjectContainer->getOverblogGraphql_Command_DumpSchemaService() at /home/renatomefi/Workspace/PHP/graphql/test-debug-bug/vendor/symfony/dependency-injection/Container.php:336
 Symfony\Component\DependencyInjection\Container->get() at /home/renatomefi/Workspace/PHP/graphql/test-debug-bug/vendor/symfony/framework-bundle/Console/Application.php:145
 Symfony\Bundle\FrameworkBundle\Console\Application->registerCommands() at /home/renatomefi/Workspace/PHP/graphql/test-debug-bug/vendor/symfony/framework-bundle/Console/Application.php:105
 Symfony\Bundle\FrameworkBundle\Console\Application->all() at /home/renatomefi/Workspace/PHP/graphql/test-debug-bug/vendor/symfony/framework-bundle/Console/Application.php:69
 Symfony\Bundle\FrameworkBundle\Console\Application->doRun() at /home/renatomefi/Workspace/PHP/graphql/test-debug-bug/vendor/symfony/console/Application.php:125
 Symfony\Component\Console\Application->run() at /home/renatomefi/Workspace/PHP/graphql/test-debug-bug/bin/console:36

I'm trying to figure out what to do, what I tried was to lazy load the commands but didn't work yet

Somewhat related
https://symfony.com/blog/new-in-symfony-3-4-lazy-commands

[mcg-web]

@renatomefi you point exactly the issue, I lazy load RequestExecutor to stay compatible with Symfony < 3.4

[mcg-web]

Now getting a way to add a test covering this is a bigger tasks :D

[renatomefi]

@mcg-web it's really tricky indeed! What I tried to see is if I could make the RequestExecutor be lazy by itself, not container wise

[mcg-web]

I'm not sure there is any other solution right now

[renatomefi]

The bug seems fixed right now, so the only "problem" is injecting the container right? I think we can close this one

[mcg-web]

yes I'm closing this, thank you for the help @renatomefi