Optimize react promise #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ooflorent
suggested changes
Jan 27, 2017
|
|
||
| // wait until promise resolution | ||
| while ($wait) { | ||
| $reactPromise->then(function ($values) use (&$resolvedValue, &$wait) { |
There was a problem hiding this comment.
Add a comment inside this block to explain why
There was a problem hiding this comment.
Maybe adding usleep(1) would make it less CPU intensive without sacrificing the performance
Also remove dead code and add react promise composer suggest.
mcg-web
force-pushed
the
optimizations
branch
from
3dc80d5 to
cfb1d27
Compare
ooflorent
approved these changes
Jan 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix memory leak in react adapter wait
Also remove dead code and add react promise composer suggest.