Fix sf toolbar updates when using graphiql #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcg-web
force-pushed
the
fix-sf-toolbar-update
branch
from
91ed4cf to
9ae7e62
Compare
ooflorent
approved these changes
Feb 13, 2017
| if (typeof Sfjs !== "undefined" && xdebugToken) { | ||
| var toolbarElement = document.querySelector('.sf-toolbar') | ||
| Sfjs.load(toolbarElement.id, '/_wdt/' + xdebugToken) | ||
| var debugUrlPattern = "{{ url('_wdt', {'token': '+TOKEN+'}) }}" |
There was a problem hiding this comment.
Could you change this to __TOKEN__?
Takes account of the generate url to avoid 404 when using `app_dev.php` base path.
mcg-web
force-pushed
the
fix-sf-toolbar-update
branch
from
9ae7e62 to
e5ae4ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes account of the generated url to avoid 404 when using
app_dev.phpbase path.