Skip to content

Conversation

mcg-web
Copy link
Contributor

@mcg-web mcg-web commented Mar 30, 2017

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Documented? no
Fixed tickets none
License MIT

@mcg-web mcg-web requested a review from ooflorent March 30, 2017 09:39
Copy link
Contributor

@ooflorent ooflorent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2nd commit should be in another PR

->toArray();

$content = json_encode($result['data']);
$content = json_encode($result['data'], JSON_PRETTY_PRINT);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing \

@mcg-web mcg-web force-pushed the prettify-json-schema-dump branch 2 times, most recently from 23476c5 to f038ea2 Compare March 30, 2017 12:39
@mcg-web mcg-web requested a review from ooflorent March 30, 2017 12:39
@mcg-web mcg-web merged commit c150367 into overblog:master Mar 30, 2017
@mcg-web mcg-web deleted the prettify-json-schema-dump branch March 30, 2017 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants